From owner-dev-commits-ports-main@freebsd.org  Thu Jul 22 09:37:21 2021
Return-Path: <owner-dev-commits-ports-main@freebsd.org>
Delivered-To: dev-commits-ports-main@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id E76EB65736B;
 Thu, 22 Jul 2021 09:37:21 +0000 (UTC)
 (envelope-from mandree@FreeBSD.org)
Received: from smtp.freebsd.org (smtp.freebsd.org
 [IPv6:2610:1c1:1:606c::24b:4])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4GVnRP6HwXz3Q96;
 Thu, 22 Jul 2021 09:37:21 +0000 (UTC)
 (envelope-from mandree@FreeBSD.org)
Received: from mandree.no-ip.org
 (p200300d027123d006b6b9314e06e441b.dip0.t-ipconnect.de
 [IPv6:2003:d0:2712:3d00:6b6b:9314:e06e:441b])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 (Authenticated sender: mandree/mail)
 by smtp.freebsd.org (Postfix) with ESMTPSA id A37F731FB2;
 Thu, 22 Jul 2021 09:37:21 +0000 (UTC)
 (envelope-from mandree@FreeBSD.org)
Received: from ryzen.an3e.de (localhost [IPv6:::1])
 by ryzen.an3e.de (Postfix) with ESMTP id 4FA8212117E;
 Thu, 22 Jul 2021 11:37:19 +0200 (CEST)
Subject: Re: git: 17db9a3291e9 - main - Mk/bsd.port.mk: fix typo in .warning
To: Alexey Dokuchaev <danfe@freebsd.org>
Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org,
 dev-commits-ports-main@freebsd.org
References: <202107220923.16M9NTCs062056@gitrepo.freebsd.org>
 <YPk6d/9l1EAnX386@FreeBSD.org>
From: Matthias Andree <mandree@FreeBSD.org>
Message-ID: <81d7d9bb-e35b-4c75-898f-c5fb58da2f8b@FreeBSD.org>
Date: Thu, 22 Jul 2021 11:37:19 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <YPk6d/9l1EAnX386@FreeBSD.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-BeenThere: dev-commits-ports-main@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Commits to the main branch of the FreeBSD ports repository
 <dev-commits-ports-main.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/dev-commits-ports-main>, 
 <mailto:dev-commits-ports-main-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/dev-commits-ports-main/>
List-Post: <mailto:dev-commits-ports-main@freebsd.org>
List-Help: <mailto:dev-commits-ports-main-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/dev-commits-ports-main>, 
 <mailto:dev-commits-ports-main-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Jul 2021 09:37:22 -0000

Am 22.07.21 um 11:29 schrieb Alexey Dokuchaev:
> On Thu, Jul 22, 2021 at 09:23:29AM +0000, Matthias Andree wrote:
>> commit 17db9a3291e9e8b62af035ee1b22160be465976a
>>
>>     Mk/bsd.port.mk: fix typo in .warning
>>     
>>     vertion -> version.
>>     
>> --- a/Mk/bsd.port.mk
>> +++ b/Mk/bsd.port.mk
>> @@ -1216,7 +1216,7 @@ _PKG_BEFORE_PKGEXT!= ${PKG_BIN} version -t ${_PKG_VERSION:C/-.*//g} 1.17.0
>>  .if ${_PKG_BEFORE_PKGEXT} == "<"
>>  _PKG_TRANSITIONING_TO_NEW_EXT=	yes
>>  _EXPORTED_VARS+=	_PKG_TRANSITIONING_TO_NEW_EXT
>> -.warning "It is strongly recommanded to upgrade to a newer vertion of pkg first"
>> +.warning "It is strongly recommanded to upgrade to a newer version of pkg first"
> 
> When fixing typos, it's usually a good idea to check if thre are more
> of them around (e.g., "recommanded").  I'd probably just grepped for
> .warning and .error strings and run aspell(1) over them.
> 
> ./danfe
> 

Yeah, right, sorry for the incomplete fix. Fixed in 4f62d3170cfc.

However, the *spell-checking matter is one for the the original
committer (in Bcc:) in the first place though.