From owner-freebsd-current Mon Jan 6 8:22:48 2003 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9D89D37B401; Mon, 6 Jan 2003 08:22:47 -0800 (PST) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 054A043E4A; Mon, 6 Jan 2003 08:22:47 -0800 (PST) (envelope-from robert@fledge.watson.org) Received: from fledge.watson.org (fledge.pr.watson.org [192.0.2.3]) by fledge.watson.org (8.12.6/8.12.5) with SMTP id h06GMj1Z097365; Mon, 6 Jan 2003 11:22:46 -0500 (EST) (envelope-from robert@fledge.watson.org) Date: Mon, 6 Jan 2003 11:22:45 -0500 (EST) From: Robert Watson X-Sender: robert@fledge.watson.org To: Mike Barcroft Cc: current@FreeBSD.org Subject: Re: alpha tinderbox failure In-Reply-To: <20030106104536.C24442@espresso.q9media.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, 6 Jan 2003, Mike Barcroft wrote: > These new truncated lines only make problems harder to solve. > > Anyway, the problem is the 5th argument to vn_extattr_get() should be an > int *, but it's passing a size_t *. It looks like most consumers of > vn_extattr_get() would prefer a size_t *, so maybe the interface should > be changed. I think the problem originated because uio_resid is 'int', but iovec's len is size_t. I agree the right answer is to use size_t as the argument to vn_extattr_{get,set}(). Will that cause type problems with the resid field, however? Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Network Associates Laboratories To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message