From owner-cvs-src@FreeBSD.ORG Tue Mar 28 18:28:27 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D654B16A512; Tue, 28 Mar 2006 18:28:27 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (tim.des.no [194.63.250.121]) by mx1.FreeBSD.org (Postfix) with ESMTP id A46E44415E; Tue, 28 Mar 2006 18:05:18 +0000 (GMT) (envelope-from des@des.no) Received: from tim.des.no (localhost [127.0.0.1]) by spam.des.no (Postfix) with ESMTP id BCADA2096; Tue, 28 Mar 2006 20:05:13 +0200 (CEST) X-Spam-Tests: AWL,BAYES_00,FORGED_RCVD_HELO X-Spam-Learn: ham X-Spam-Score: -2.4/3.0 X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on tim.des.no Received: from xps.des.no (des.no [80.203.243.180]) by tim.des.no (Postfix) with ESMTP id 3FFC42081; Tue, 28 Mar 2006 20:05:13 +0200 (CEST) Received: by xps.des.no (Postfix, from userid 1001) id 09BF133C8D; Tue, 28 Mar 2006 20:05:13 +0200 (CEST) From: des@des.no (Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?=) To: John Baldwin References: <200603281434.k2SEYmaR031447@repoman.freebsd.org> <200603281032.10624.jhb@freebsd.org> <86y7yuwn01.fsf@xps.des.no> <200603281300.09419.jhb@freebsd.org> Date: Tue, 28 Mar 2006 20:05:12 +0200 In-Reply-To: <200603281300.09419.jhb@freebsd.org> (John Baldwin's message of "Tue, 28 Mar 2006 13:00:06 -0500") Message-ID: <86psk6wilj.fsf@xps.des.no> User-Agent: Gnus/5.110003 (No Gnus v0.3) Emacs/21.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/i386/include atomic.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Mar 2006 18:28:28 -0000 John Baldwin writes: > One reason for not having the casts, btw, is that you lose type > checking. Huh? Before my patch, any use of atomic_*_ptr with warnings turned off would result in a slew of warnings because you'd be passing pointers to a function which is declared to take u_int. The only way to make this type safe is to use inline functions instead of the macros I wrote. DES --=20 Dag-Erling Sm=F8rgrav - des@des.no