From nobody Thu Jan 29 18:05:41 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f26Wg6dB0z6PcjG; Thu, 29 Jan 2026 18:05:51 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f26Wg5wlLz3X2n; Thu, 29 Jan 2026 18:05:51 +0000 (UTC) (envelope-from bz@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769709951; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MU0lROsf6b68YqlqSr5DmwP4cB9HzlVVNjjbcEEQiLQ=; b=dFhb7kRH1Og4w+g3pU9iHy/GhqQMkyqZ7DC44LLwst+8jaEiVbOeaCMWNtNtx6KS3OtUT/ Co9er6cZhtEMuh1KjplOSQfOzhRKqKCtSrd19GivddJHQo8ey9m8h/QA2Na6K8cqU79dJC fsZHshtFd/BlfOIl4w98C1qZUN9IiPygAgoF/5Ek6P6z27Gi60W4dZ0U0c+tbDllXJoFHT ej0nZ3ioeZ6wB4sKQlnCxH7Xdssl/VDQtQF5B2dWd1gBrmb5JOEjlZdRPiAe2fHF77O1Vr NJyLVBY6FE0r+Mm9g9IM5VLdFyx6yb1nfYhdwkt9fd/gyFlSKgErw/VV55sKDw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1769709951; a=rsa-sha256; cv=none; b=lLW0WDCM6t8kkevkzJnlGOa/iT4U1gpFR0Q751jieb9KKQThYBa/3bKWGFSxrlUsBj6FQH EQ+7tNd4XUAu3tshUd4iFuJpYaUJV6f7S4lDeexI1BAMs4OssuJK2T81irfEfAmG3bputj GPx8LWAvYuYi6xxtOGu9m5x1oioAPvRVPQKguRUS0skoNTGO0mBnGXTGvXCDqQPdcvx8TK v4cFeq95RDXyJyEG1VI15acPVXSsP08mvMXX12JyFRewf5gw1M4wDMelqszlrXePMKlbXU RBjEzcHxr5NM9elYQ5sBJ0z3MSvT7KYjhnxRW0PCHg7pTGeRv9vrWghOevUL/A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769709951; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MU0lROsf6b68YqlqSr5DmwP4cB9HzlVVNjjbcEEQiLQ=; b=yWiAfqs0sqnss9rZHUl53g3E9x/FwJWZeMVXQbwA0FAv/mFaMxLoJEl28iAau6RvaRHnf1 HBklejrWZLgOG3bhuvNZ/Bh1YI6AqSm26kofKCcg7T7/w0ojLkLhWOjtl7xPa6TWzO42YS psO1PuDJIOrS8iyvGYjfw6Ggh065MqbPg/WIcUi9kYsbii0ZO7n58uNwjFj4tt36u//L+i Lif1jAddTQb1FvIU7dDEqo8xfg5n9uStOUQ/141wy2LTwUhgrSO9ua31x0k45ywmVXgJMa thFsTEXcYAz7I8rbAa1NH7tlTOhT7vE5xbL43Bcu7qGFYQxmX5pM8PQF87BOuQ== Received: from mx-01.divo.sbone.de (mx-01.divo.sbone.de [IPv6:2003:a:140a:2200:6:594:fffe:19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (prime256v1) client-digest SHA256) (Client CN "mx-01.divo.sbone.de", Issuer "E8" (verified OK)) (Authenticated sender: bz/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4f26Wg4Ct8zKjf; Thu, 29 Jan 2026 18:05:51 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by mx-01.divo.sbone.de (Postfix) with ESMTPS id 44F2BA64806; Thu, 29 Jan 2026 18:05:27 +0000 (UTC) Received: from content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 6CD902D029E8; Thu, 29 Jan 2026 18:05:44 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) by content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (amavisd-new, port 10024) with ESMTP id wW-OvWEaUJ6U; Thu, 29 Jan 2026 18:05:42 +0000 (UTC) Received: from nv.t4-02.sbone.de (nv.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:22]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id D1F932D029D8; Thu, 29 Jan 2026 18:05:42 +0000 (UTC) Date: Thu, 29 Jan 2026 18:05:41 +0000 (UTC) From: "Bjoern A. Zeeb" To: Aymeric Wibo cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: c5daa5a4c32c - main - acpi_spmc: Add system power management controller driver In-Reply-To: <69776f5e.2500f.227efeb7@gitrepo.freebsd.org> Message-ID: <44q7361r-p46r-r885-6p7q-62r5489ps510@mnoonqbm.arg> References: <69776f5e.2500f.227efeb7@gitrepo.freebsd.org> X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed On Mon, 26 Jan 2026, Aymeric Wibo wrote: > The branch main has been updated by obiwac: > > URL: https://cgit.FreeBSD.org/src/commit/?id=c5daa5a4c32c9b1ecb506ddf1a80579c93c3ea6d > > commit c5daa5a4c32c9b1ecb506ddf1a80579c93c3ea6d > Author: Aymeric Wibo > AuthorDate: 2025-06-14 15:30:44 +0000 > Commit: Aymeric Wibo > CommitDate: 2026-01-26 13:42:11 +0000 > > acpi_spmc: Add system power management controller driver > > Add SPMC (system power management controller) driver as acpi_spmc. This > is the device which provides the LPI device D-state constraints and > allows for OSPM to send S0ix/modern standby entry/exit notifications. > This supports the original Intel DSM > (https://uefi.org/sites/default/files/resources/Intel_ACPI_Low_Power_S0_Idle.pdf, > untested), the AMD DSM (tested), and the Microsoft DSM (tested). > > Before entry, acpi_spmc_check_constraints is called to notify of any > violated power constraints. This will use acpi_pwr_get_state to get > current device D-states when that gets added back. > > Reviewed by: olce > Tested by: jkim, Oleksandr Kryvulia, Matthias Lanter > Approved by: olce > Sponsored by: The FreeBSD Foundation > Differential Revision: https://reviews.freebsd.org/D48387 > --- > share/man/man4/acpi.4 | 4 +- > sys/conf/files | 1 + > sys/dev/acpica/acpi.c | 1 + > sys/dev/acpica/acpi_spmc.c | 618 +++++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 623 insertions(+), 1 deletion(-) > diff --git a/sys/dev/acpica/acpi_spmc.c b/sys/dev/acpica/acpi_spmc.c > new file mode 100644 > index 000000000000..57593d9ccae1 > --- /dev/null > +++ b/sys/dev/acpica/acpi_spmc.c .... > + > +static int > +acpi_spmc_suspend(device_t dev) > +{ > + acpi_spmc_display_off_notif(dev); > + acpi_spmc_entry_notif(dev); > + > + return (0); > +} > + > +static int > +acpi_spmc_resume(device_t dev) > +{ > + acpi_spmc_exit_notif(dev); > + acpi_spmc_display_on_notif(dev); > + > + return (0); > +} Those two functions are not hooked up to device methods and thus are currently unused. Will they be used? > +static device_method_t acpi_spmc_methods[] = { > + DEVMETHOD(device_probe, acpi_spmc_probe), > + DEVMETHOD(device_attach, acpi_spmc_attach), > + DEVMETHOD(device_detach, acpi_spmc_detach), > + DEVMETHOD_END > +}; > + > +static driver_t acpi_spmc_driver = { > + "acpi_spmc", > + acpi_spmc_methods, > + sizeof(struct acpi_spmc_softc), > +}; > + > +DRIVER_MODULE_ORDERED(acpi_spmc, acpi, acpi_spmc_driver, NULL, NULL, SI_ORDER_ANY); > +MODULE_DEPEND(acpi_spmc, acpi, 1, 1, 1); > > -- Bjoern A. Zeeb r15:7