From owner-p4-projects@FreeBSD.ORG  Tue Feb 14 03:35:44 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 7C5EF16A438; Tue, 14 Feb 2006 03:35:42 +0000 (GMT)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id CD97816A4EF
	for <perforce@freebsd.org>; Tue, 14 Feb 2006 03:35:41 +0000 (GMT)
	(envelope-from marcel@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B49E643D75
	for <perforce@freebsd.org>; Tue, 14 Feb 2006 03:35:39 +0000 (GMT)
	(envelope-from marcel@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id k1E3ZdiW049502
	for <perforce@freebsd.org>; Tue, 14 Feb 2006 03:35:39 GMT
	(envelope-from marcel@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id k1E3ZdXa049499
	for perforce@freebsd.org; Tue, 14 Feb 2006 03:35:39 GMT
	(envelope-from marcel@freebsd.org)
Date: Tue, 14 Feb 2006 03:35:39 GMT
Message-Id: <200602140335.k1E3ZdXa049499@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	marcel@freebsd.org using -f
From: Marcel Moolenaar <marcel@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 91721 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Feb 2006 03:35:44 -0000

http://perforce.freebsd.org/chv.cgi?CH=91721

Change 91721 by marcel@marcel_nfs on 2006/02/14 03:34:53

	o  Don't set the newly allocated resource's start and end,
	   because those are rman internals and implement the rman
	   without needing them.
	o  Fix a misleading comment.

Affected files ...

.. //depot/projects/uart/dev/scc/scc_core.c#7 edit

Differences ...

==== //depot/projects/uart/dev/scc/scc_core.c#7 (text+ko) ====

@@ -181,8 +181,6 @@
 		    sc->sc_rrid);
 		rle->res = malloc(sizeof(struct resource), M_SCC,
 		    M_WAITOK | M_ZERO);
-		rman_set_start(rle->res, rle->start);
-		rman_set_end(rle->res, rle->end);
 		bus_space_subregion(rman_get_bustag(sc->sc_rres),
 		    rman_get_bushandle(sc->sc_rres),
 		    start - rman_get_start(sc->sc_rres), size, &bh);
@@ -257,8 +255,7 @@
 	 * Allocate the register resource. We assume that all SCCs have a
 	 * single register window in either I/O port space or memory mapped
 	 * I/O space. Any SCC that needs multiple windows will consequently
-	 * not be supported by this driver as-is. We try I/O port space
-	 * first to satisfy the EBus code.
+	 * not be supported by this driver as-is.
 	 */
 	sc->sc_rrid = 0;
 	sc->sc_rtype = SYS_RES_MEMORY;