From owner-freebsd-net@FreeBSD.ORG Mon Oct 30 07:44:22 2006 Return-Path: X-Original-To: freebsd-net@freebsd.org Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 21B8616A40F for ; Mon, 30 Oct 2006 07:44:22 +0000 (UTC) (envelope-from sivakumar.subramani@wipro.com) Received: from wip-ectls-mx1.wipro.com (wip-ectls-mx1.wipro.com [203.91.193.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1DA8643D45 for ; Mon, 30 Oct 2006 07:44:21 +0000 (GMT) (envelope-from sivakumar.subramani@wipro.com) Received: from wip-ectls-mx1.wipro.com (localhost.localdomain [127.0.0.1]) by localhost (Postfix) with ESMTP id 6F6912201DE for ; Mon, 30 Oct 2006 13:14:29 +0530 (IST) Received: from blr-ec-bh02.wipro.com (blr-ec-bh02.wipro.com [10.201.50.92]) by wip-ectls-mx1.wipro.com (Postfix) with ESMTP id 60F8A220366 for ; Mon, 30 Oct 2006 13:14:29 +0530 (IST) Received: from blr-m3-msg.wipro.com ([10.114.50.99]) by blr-ec-bh02.wipro.com with Microsoft SMTPSVC(6.0.3790.1830); Mon, 30 Oct 2006 13:14:18 +0530 X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Date: Mon, 30 Oct 2006 13:13:12 +0530 Message-ID: <821C7AD2A9F78942B86059792262577315B049@blr-m3-msg.wipro.com> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: RFC: TSO patch for current Thread-Index: AcbROYB1Rf1yJ1cwQEG3PZW6avyqWQqvWjIg From: To: X-OriginalArrivalTime: 30 Oct 2006 07:44:18.0911 (UTC) FILETIME=[34DE36F0:01C6FBF7] Cc: freebsd-net@freebsd.org Subject: RE: RFC: TSO patch for current X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Oct 2006 07:44:22 -0000 =0D Hi Jack, Do you the patch for 6.0 FreeBSD kernel? If so can you please send it me. I would like to test TSO on my system. Thanks, ~Siva -----Original Message----- From: owner-freebsd-net@freebsd.org [mailto:owner-freebsd-net@freebsd.org] On Behalf Of Jack Vogel Sent: Wednesday, September 06, 2006 3:53 AM To: Andre Oppermann Cc: freebsd-net; freebsd-current Subject: Re: RFC: TSO patch for current On 9/5/06, Andre Oppermann wrote: > Jack Vogel wrote: > > On 9/5/06, Andre Oppermann wrote: > >> Prafulla Deuskar wrote: > >> > Your patch looks good and is the way to go. > >> > > >> > So after Jack confirms that your patch works with the em driver=0D > >> > would you commit to to -current? > >> > >> Absolutely. :-) > >> > >> > The driver related changes can follow.. > >> > > >> > Later we also need to fix ifconfig so that user can=0D > >> > enable/disable > >> TSO on the interface. > >> > >> I'll do that together with the TSO code. > > > > OK, I've built and done some touch testing of this. I like it, the=0D > > driver has some counters of the number of TSO bursts it does, and I=0D > > think I see more per netperf test with your patch than mine. > > > > Hard to do real performance testing with all that WITNESS stuff in,=0D > > but I will be making a 6.1 version of your patch to test with since=0D > > I have my driver running on that anyway. > > You can disable WITNESS and INVARIANTS pretty easily in -current and=0D > get the full performance with it. Last time I tried that I think the kernel wouldnt build, but that was like 6 months ago, so I just kicked off a build with this stuff off, and we'll see how it looks :) > > If you do the ifconfig changes there will need to be a small amount=0D > > of code added to em_ioctl() but it should be trivial. > > > > You want me to reissue a driver patch with changes for your code? > > Yes, please do so. I've got a dual-em card which I can test with myself. OK, attached new patch, this one even has the ioctl change so when you get the ifconfig change in it will be ready. Cheers, Jack The information contained in this electronic message and any attachments to= this message are intended for the exclusive use of the addressee(s) and= may contain proprietary, confidential or privileged information. If you= are not the intended recipient, you should not disseminate, distribute or= copy this e-mail. Please notify the sender immediately and destroy all= copies of this message and any attachments.=0D WARNING: Computer viruses can be transmitted via email. The recipient= should check this email and any attachments for the presence of viruses.= The company accepts no liability for any damage caused by any virus= transmitted by this email. =0D www.wipro.com