From owner-svn-src-head@freebsd.org  Thu Oct  4 07:56:38 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id CB1EE10C3481;
 Thu,  4 Oct 2018 07:56:38 +0000 (UTC)
 (envelope-from rwatson@FreeBSD.org)
Received: from cyrus.watson.org (cyrus.watson.org [204.107.128.30])
 by mx1.freebsd.org (Postfix) with ESMTP id 69AD988E6C;
 Thu,  4 Oct 2018 07:56:38 +0000 (UTC)
 (envelope-from rwatson@FreeBSD.org)
Received: from [10.0.1.4] (host81-132-222-21.range81-132.btcentralplus.com
 [81.132.222.21])
 by cyrus.watson.org (Postfix) with ESMTPSA id 6AE60C1420;
 Thu,  4 Oct 2018 07:56:37 +0000 (UTC)
Mime-Version: 1.0 (1.0)
Subject: Re: svn commit: r339085 - head/sys/security/audit
From: "Robert N. M. Watson" <rwatson@FreeBSD.org>
X-Mailer: iPad Mail (15G77)
In-Reply-To: <CAOtMX2iq7B=qRGCAsxJLDXuYAQYBS17NnDhRunfwyRu0LB8XuA@mail.gmail.com>
Date: Thu, 4 Oct 2018 08:56:32 +0100
Cc: Robert Watson <rwatson@freebsd.org>,
 src-committers <src-committers@freebsd.org>,
 svn-src-all <svn-src-all@freebsd.org>,
 svn-src-head <svn-src-head@freebsd.org>
Message-Id: <E5E3F906-8A21-4BB0-B30B-5EFF939BB689@FreeBSD.org>
References: <201810021558.w92FwHBp025418@repo.freebsd.org>
 <CAOtMX2iq7B=qRGCAsxJLDXuYAQYBS17NnDhRunfwyRu0LB8XuA@mail.gmail.com>
To: Alan Somers <asomers@freebsd.org>
Content-Type: text/plain;
	charset=us-ascii
Content-Transfer-Encoding: quoted-printable
X-Content-Filtered-By: Mailman/MimeDel 2.1.27
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Oct 2018 07:56:39 -0000

On 2 Oct 2018, at 18:15, Alan Somers <asomers@freebsd.org> wrote:

>>   3. Remove a check of trail enablement/suspension from audit_new() --
>>      at the point where this function has been entered, we believe that
>>      system-call auditing is already in force, or we wouldn't get here,
>>      so simply proceed to more expensive policy checks.
>=20
> Did you check the logic around audit_proc_coredump too?  I think this chan=
ge will cause AUE_CORE events to be emitted even when auditing is disabled.

This should be caught by audit_commit(), although it probably would be sligh=
tly preferable for audit_proc_coredump() to have an explicit policy check ea=
rlier, avoiding a memory allocation (but not a big deal).

Robert=