From owner-cvs-all@FreeBSD.ORG Sat Feb 18 17:49:07 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8658516A420; Sat, 18 Feb 2006 17:49:07 +0000 (GMT) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (arm132.internetdsl.tpnet.pl [83.17.198.132]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7E72143D45; Sat, 18 Feb 2006 17:49:06 +0000 (GMT) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 0E35051688; Sat, 18 Feb 2006 18:49:05 +0100 (CET) Received: from localhost (dlm157.neoplus.adsl.tpnet.pl [83.24.42.157]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id A5EFF50B5D; Sat, 18 Feb 2006 18:48:58 +0100 (CET) Date: Sat, 18 Feb 2006 18:48:46 +0100 From: Pawel Jakub Dawidek To: Andre Oppermann Message-ID: <20060218174846.GD849@garage.freebsd.pl> References: <200602181716.k1IHGIR9050645@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="veXX9dWIonWZEC6h" Content-Disposition: inline In-Reply-To: <200602181716.k1IHGIR9050645@repoman.freebsd.org> X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 7.0-CURRENT i386 User-Agent: mutt-ng/devel-r535 (FreeBSD) X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=BAYES_00,RCVD_IN_NJABL_DUL, RCVD_IN_SORBS_DUL,UPPERCASE_25_50 autolearn=no version=3.0.4 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern uipc_domain.c uipc_mbuf.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Feb 2006 17:49:07 -0000 --veXX9dWIonWZEC6h Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Feb 18, 2006 at 05:16:18PM +0000, Andre Oppermann wrote: +> andre 2006-02-18 17:16:18 UTC +>=20 +> FreeBSD src repository +>=20 +> Modified files: +> sys/kern uipc_domain.c uipc_mbuf.c=20 +> Log: +> The sysctls kern.ipc.[max_linkhdr|max_protohdr|max_hdr|max_datalen] +> can't be changed from userland. Make them read-only and provide +> descriptions. [...] +> -SYSCTL_INT(_kern_ipc, KIPC_MAX_LINKHDR, max_linkhdr, CTLFLAG_RW, +> - &max_linkhdr, 0, ""); +> -SYSCTL_INT(_kern_ipc, KIPC_MAX_PROTOHDR, max_protohdr, CTLFLAG_RW, +> - &max_protohdr, 0, ""); +> -SYSCTL_INT(_kern_ipc, KIPC_MAX_HDR, max_hdr, CTLFLAG_RW, &max_hdr, 0, "= "); +> -SYSCTL_INT(_kern_ipc, KIPC_MAX_DATALEN, max_datalen, CTLFLAG_RW, +> - &max_datalen, 0, ""); +> +SYSCTL_INT(_kern_ipc, KIPC_MAX_LINKHDR, max_linkhdr, CTLFLAG_RD, +> + &max_linkhdr, 0, "Size of largest link layer header"); +> +SYSCTL_INT(_kern_ipc, KIPC_MAX_PROTOHDR, max_protohdr, CTLFLAG_RD, +> + &max_protohdr, 0, "Size of largest protocol layer header"); +> +SYSCTL_INT(_kern_ipc, KIPC_MAX_HDR, max_hdr, CTLFLAG_RD, +> + &max_hdr, 0, "Size of largest link plus protocol header"); +> +SYSCTL_INT(_kern_ipc, KIPC_MAX_DATALEN, max_datalen, CTLFLAG_RD, +> + &max_datalen, 0, "Minimum space left in mbuf after max_hdr"); I haven't looked at all of them, but let's take max_linkhdr. If it is read-only, where is it actually set to some value? The only place I found is sys/kern/uipc_domain.c:domaininit(): if (max_linkhdr < 16) /* XXX */ max_linkhdr =3D 16; Which doesn't make any sense. Maybe it should be a tunable? --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --veXX9dWIonWZEC6h Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFD913+ForvXbEpPzQRAs+XAJ9SZbeCqM+HTualgyel2U2y3zrbaQCeJr2E VSjkVXace9VP90LYckMqPHk= =BjIj -----END PGP SIGNATURE----- --veXX9dWIonWZEC6h--