From owner-svn-ports-all@FreeBSD.ORG  Thu Mar 28 06:11:54 2013
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 4A3E120B;
 Thu, 28 Mar 2013 06:11:54 +0000 (UTC) (envelope-from rea@codelabs.ru)
Received: from 0.mx.codelabs.ru (0.mx.codelabs.ru [144.206.233.71])
 by mx1.freebsd.org (Postfix) with ESMTP id D7257A5D;
 Thu, 28 Mar 2013 06:11:53 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=codelabs.ru;
 s=three; 
 h=Sender:In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date;
 bh=19JWxiExY3yI8L8wjAwNQNFyuaGUYBJ8fsWgiaUrR1I=; 
 b=kBC7YTD0x/Io7+DQnr3IhajtapvdiBABOmNtaN+WNGWmZHI6jewgBkcQccuLw5F6Fo6mkFKyheY0YvIQM5RrXj7/X3YOA5M46tQJ/c+AsVwMSbBZ9sw5fazWNjjzPn7xdoK9MuQLpP5kPTiIK9HtV93zxZFOtCjLrkLD+PYOYF0wg/ZELIb78oKweHAyKwKBra9EHRdnCvc2ljFRSpOtTVMuy0bFbTxeh1FC1a6HNbzPaoKlU7Mujak8SMnzua94A5s9C+1ezGOAn8upeI+SLKNIlSrQuj9Qr91cAnjaR5p0OZ6M4QjSKdD0ISSZp4rJ6eOeVMJb6iO04/5sVZv8dcP8ywRc5BxXKcpsg1GmLkrPB1+UA2a58kUTD7vbwElPK2jJdWqm7v7ps/fDEH5Q4o3Hix/t9t7x/pEnqjW4zvukHSx6t+dGoXxgC0wUEvcMnJvxNhn9cDZ1XdqE6vFhkYEgaItfKlxkGYnvRklQ/6ideN/OWd94q4B+iiUrlMNFblvexim5f6Bx5/OnzXqOYSiUELbcJLvJWAe2W9eoFci13MB4w/AP7kifDYUqA4a05BU7FbBmkFElTZGiNxigZdcaJJQ0oHHyKaFm0FOvc0Dy+x31rCCtMtyZmbRtyMr9wQ09KOBcN2tz+PEyk5JpXQGwcUBopgFjzkWdtyJm9iQ=;
Received: from void.codelabs.ru (void.codelabs.ru [144.206.233.66])
 by 0.mx.codelabs.ru with esmtpsa (TLSv1:DHE-RSA-AES256-SHA:256)
 id 1UL63z-000DRB-Tl; Thu, 28 Mar 2013 10:11:52 +0400
Date: Thu, 28 Mar 2013 10:11:49 +0400
From: Eygene Ryabinkin <rea@freebsd.org>
To: Alexey Dokuchaev <danfe@FreeBSD.org>
Subject: Re: svn commit: r315412 - head/security/vuxml
Message-ID: <y6wrz9PFYnyLw6do0J4WTT7Agfw@7Kz+GRmbm4U3A9gdU2CEwxjTOhk>
References: <201303272044.r2RKipXq050003@svn.freebsd.org>
 <20130328024114.GA72629@FreeBSD.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature"; boundary="nO3oAMapP4dBpMZi"
Content-Disposition: inline
In-Reply-To: <20130328024114.GA72629@FreeBSD.org>
Sender: rea@codelabs.ru
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 Xin LI <delphij@FreeBSD.org>, ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 28 Mar 2013 06:11:54 -0000


--nO3oAMapP4dBpMZi
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Thu, Mar 28, 2013 at 02:41:14AM +0000, Alexey Dokuchaev wrote:
> On Wed, Mar 27, 2013 at 08:44:51PM +0000, Xin LI wrote:
> > New Revision: 315412
> > URL: http://svnweb.freebsd.org/changeset/ports/315412
> >=20
> > Log:
> >   Explicitly use -E for sed(1).
> >  =20
> >   Submitted by:	des
> >   Reviewed by:	eadler
> >=20
> > -	@unexpand "${VUXML_FILE}" | ${SED} 's,[[:space:]]*$$,,g' > "${VUXML_F=
ILE}.unexpanded"
> > +	@unexpand "${VUXML_FILE}" | ${SED} -E 's,[[:space:]]*$$,,g' > "${VUXM=
L_FILE}.unexpanded"
>=20
> Why -e is insufficient here?

Well, slightly better question is 'why had you added -E that enabled
modern re processing', because the change from '${SED} <pattern>' to
'${SED} -e <pattern>' is a no-op.  And the right answer is "That was
a redundant change":
{{{
$ echo SSBoYXZlIHRyYWlsaW5nIHNwYWNlLCBjbGVhbiBtZSEJCSAK | openssl base64 -d=
 | sed 's/[[:space:]]*$/<fixed>/g'
I have trailing space, clean me!<fixed>

$ echo SSBoYXZlIHRyYWlsaW5nIHNwYWNlLCBjbGVhbiBtZSEJCSAK | openssl base64 -d=
 | sed -E 's/[[:space:]]*$/<fixed>/g'
I have trailing space, clean me!<fixed>
}}}

We will try to fix that or to understand why des@ suggested it,
thanks for spotting!
--=20
Eygene Ryabinkin                                        ,,,^..^,,,
[ Life's unfair - but root password helps!           | codelabs.ru ]
[ 82FE 06BC D497 C0DE 49EC  4FF0 16AF 9EAE 8152 ECFB | freebsd.org ]

--nO3oAMapP4dBpMZi
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iF4EABEIAAYFAlFT3yUACgkQFq+eroFS7PtRaAEAhrRZIjucgRPVn7H+gWbqsaW1
QeNgWev7hPfw2C2KhWUA/2Ict4DVfO06xeQ8XLNO151DI/WcIdmlL24bganSpBYt
=zytk
-----END PGP SIGNATURE-----

--nO3oAMapP4dBpMZi--