From owner-svn-src-projects@freebsd.org Thu May 26 00:15:10 2016 Return-Path: Delivered-To: svn-src-projects@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 15F79B4AF9E for ; Thu, 26 May 2016 00:15:10 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-oi0-x231.google.com (mail-oi0-x231.google.com [IPv6:2607:f8b0:4003:c06::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CF234195E; Thu, 26 May 2016 00:15:09 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-oi0-x231.google.com with SMTP id b65so100061967oia.1; Wed, 25 May 2016 17:15:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc; bh=V607HteesOLICMcmKIKCLLGLtOWGd3OHHqCtxI/Jktg=; b=pkq372OTkV8Fh7OlQViJGvsMAE1Lgc/hS9jIPs0rKFDhF1huSqmm1zM+VB0vF5Z1Bq 31OwQc4IcMgrpafWJgU6ivIGJa8LntuD2fYBoDhVqEsxWJbp2Ne8nQwy0eK9bgF2bObH 62Hzig0gdXtzvly4mygvCDhnWwT8+CauRjXW9Y4uaKwNYpgUYg5Y6Uf851EGzVT8iyCu yOZCj60Cnu37ZYeWmiwVyga2Q1x8MOls7Uf4yymFfOLnLStpBhrqzlvpzALDT9gGmpjK OkiGzR/iUVnOmecvHrvVGbxr1GvDfs2w9W5VdL0lPylCrF1CFtpGDikMWjZrUo7J1Zwk wv+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc; bh=V607HteesOLICMcmKIKCLLGLtOWGd3OHHqCtxI/Jktg=; b=IYFD2ywN+8d1V3K6D3E0pdCvM/Jh2M1XGNpu1IMgeBM7ybOY0BajdlR79X3ZbxW+fH uJ0odgX8MsUiUncfqc9SkzgDHPxu83dTZN0Ns74anT9InEHqMppq47EokNtDpasggaLM 5zRujIO5Szhn8Cdg+vBkZXx998gQRLr0j7sKqyWfo0ebgZwm9aES7UqqZ7nNfdRVoZ0P f3YRRr5BZNZBhhFvCKHHvgyAd/AE0RSKmMSPHwvpSjXq2HwsQ26hYnZTMNp5HjCWREKS +KwRLmC7uR4fkk3by7bxuu8Yxjdttn/NHlKFKM/sKqFrlqsZJLwth7vg41JHztyLTKyA 7OnQ== X-Gm-Message-State: ALyK8tI05FU/9SFP14F4+YnYMwx2G9VFOsFxG78jePIDuuGEoCgKjJmZV7WG57eSrMQEIOcvuyJZxh1nTSHXRQ== MIME-Version: 1.0 X-Received: by 10.202.212.19 with SMTP id l19mr4003189oig.182.1464217970332; Wed, 25 May 2016 16:12:50 -0700 (PDT) Sender: asomers@gmail.com Received: by 10.202.4.200 with HTTP; Wed, 25 May 2016 16:12:50 -0700 (PDT) In-Reply-To: References: <201605252011.u4PKBQ06063559@repo.freebsd.org> Date: Wed, 25 May 2016 17:12:50 -0600 X-Google-Sender-Auth: KzKRrOqmsivFxcA09_5aML0EVN0 Message-ID: Subject: Re: svn commit: r300695 - projects/zfsd/head/cddl/usr.sbin/zfsd/tests From: Alan Somers To: Ngie Cooper Cc: "src-committers@freebsd.org" , "svn-src-projects@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.22 X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 May 2016 00:15:10 -0000 On Wed, May 25, 2016 at 3:42 PM, Ngie Cooper wrote: > On Wed, May 25, 2016 at 1:11 PM, Alan Somers wrote: > ... > > This abandons the gcov integration, but that doesn't work with clang > anyway. > > There's no reduction in the granularity of test visibility to Kyua, > because > > the entire file was a single test from the perspective of ATF. > > gcov integration with clang worked for me last year: > > https://lists.freebsd.org/pipermail/freebsd-toolchain/2015-April/001669.html > .. > Thanks, > -Ngie > Neat! I didn't know that clang had gained support for libprofile_rt. However, I'm not going to restore zfsd's gcov integration. It seemed like a good idea at the time, but as it turned out, it's too hard to get comprehensive coverage of zfsd with unit tests alone. It simply wasn't designed with unit testing in mind. Instead, I try to get comprehensive coverage with functional tests, which may be found in base/projects/zfsd/head/tests/sys/cddl/zfs/tests/zfsd. -Alan