From owner-freebsd-current@FreeBSD.ORG Fri Apr 29 20:31:17 2005 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9993616A4CE; Fri, 29 Apr 2005 20:31:17 +0000 (GMT) Received: from harmony.village.org (rover.village.org [168.103.84.182]) by mx1.FreeBSD.org (Postfix) with ESMTP id F2A0943D5D; Fri, 29 Apr 2005 20:31:16 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.13.3/8.13.1) with ESMTP id j3TKSxNm027529; Fri, 29 Apr 2005 14:29:02 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Fri, 29 Apr 2005 14:29:40 -0600 (MDT) Message-Id: <20050429.142940.43005573.imp@bsdimp.com> To: darrenr@hub.freebsd.org From: "M. Warner Losh" In-Reply-To: <20050428155451.GA2192@hub.freebsd.org> References: <20050428152622.GC92579@ip.net.ua> <427100CC.8080604@samsco.org> <20050428155451.GA2192@hub.freebsd.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: darrenr@freebsd.org cc: current@freebsd.org Subject: Re: LINT broken due to ipfilter X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Apr 2005 20:31:17 -0000 In message: <20050428155451.GA2192@hub.freebsd.org> Darren Reed writes: : On Thu, Apr 28, 2005 at 09:27:08AM -0600, Scott Long wrote: : > Leaving the tree unbuildable for 3 days is unacceptable. I doubt that : > any other active OSS project would tolerate it, and I'm sure that Sun : > wouldn't tolerate it either. : : Well, FreeBSD seems to have a history of allowing this...I seem to recall : some other part of the build being broken when I did the initial commit : for ipf...not to mention there being many times in the past when I've seen : comments about the build being broken in one way or another. No. FreeBSD does not have a history of allowing things to be broken for 3 days. While things are sometims broken for this long, it is not considered acceptable or OK by any means. The tree must be buildable at all times, and any breakage longer than a couple of hours is not considered acceptable and the folks that have broken the tree are usually remonstrated in privated multiple times for such breakage. Given then this breakage was 10x longer than the usual threshold for private complaints, I think that the public complaint is completely justified. : My single biggest issue remains the number of boxes needed to keep things : compiling on FreeBSD. 4.11, 5.4, -current. That is a really tough ask : on anyone and last I checked, there's only a ref4 and a ref5. You only need one box to build universe for -current, since that's what you broek. : So....if you want to make it easier for people like me to make sure they : haven't broken the build, put a target in src/Makefile that achieves this. : That is, buildworld and buildkernel and build LINT and whatever else for : a single platform. Or at least I think buildworld and buildkernel are : required, seperately. "universe" is too much. "universe" can even be built using project resources. freefall usually has enough disk space. However, even if you don't do a universe, the bare minimum is buildworld, and your import didn't pass that, and the subsequent delay in fixing it was longer than is reasonable. I think you are complaining too loudly here. The fact remains that you committed the imported sources to the tree before your integration with FreeBSD sources was complete. It took several days to resolve these integration problems. That's not acceptable. Esepcailly when no heads up was given. : Having said all that, I appreciate any assistance others can give, : especially clues on what to do with rescue. Yes. That was a good thing. The community really pulled together here. Warner