Date: Thu, 4 Oct 2018 14:22:22 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Gleb Popov <arrowd@freebsd.org> Cc: Alexey Dokuchaev <danfe@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r481210 - head/lang/ghc Message-ID: <20181004122221.rz5b2qlp6xqucjbu@ivaldir.net> In-Reply-To: <CALH631=UzDL0huHHG=Y=WVHgcSNyLtRqBX5b%2Bvko7zoDNAEvZw@mail.gmail.com> References: <201810040834.w948Y9SE084351@repo.freebsd.org> <20181004090206.GA73328@FreeBSD.org> <CALH631=UzDL0huHHG=Y=WVHgcSNyLtRqBX5b%2Bvko7zoDNAEvZw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--xyrouxunwsmlcbyd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 04, 2018 at 01:14:02PM +0300, Gleb Popov wrote: > On Thu, Oct 4, 2018 at 12:02 PM Alexey Dokuchaev <danfe@freebsd.org> wrot= e: >=20 > > On Thu, Oct 04, 2018 at 08:34:09AM +0000, Gleb Popov wrote: > > > New Revision: 481210 > > > URL: https://svnweb.freebsd.org/changeset/ports/481210 > > > > > > Log: > > > lang/ghc: Remove BOOTH option. > > > > This is very bad commit message. Please always try to exlain the chang= es > > made, not simply translate the diff into English. Your mentor should h= ave > > told you that. > > > > ./danfe > > >=20 > An explanation in the Phab Diff isn't sufficient? No the explaination should be first in the commit logs which is what we all= face at first Bapt --xyrouxunwsmlcbyd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAlu2BfsACgkQY4mL3PG3 PlpB6hAAi9P3UlkJHOouIKgLolGNvo8MujyZUbd3zXqaRvJ/VgFM7cf0pueUOGKa MkUvuP49U6o/Y+4arDrcu5GZSrluuL95d7JxR+8z1a7ft7To5CV59MTjJCbIRYWW /u3RSInyrkw5Ig9ExVk89MBiN9x9/g3uFBLlTWDOGQhtzwJ0LnRKjmHaHyJOQ06K qV94uC7lgiP9FWoJexQEf+5rb43Fc4J5+nxgrhpB2K0QZe5ivmgCYBm0L6r62T2y vvhzn+2c9YyDLv+FW3AcKFLzmidKemPQBPnIlLan9UfpKebGcZBMNMfTMBvacIh4 S4hrpSpBLcbW8/Jz+H0wwHbgOyia+62B/d84kK4u45kNvCPLZyDXs3D8Gw5/mytD i3Tn9Otp1X25Kp3FDP7/Fm0l+N30eU4oGyZpwDiu+ZkXhaf4f6YsV/wTpbA6svI9 LURV7T2iV0+agqMDfzLt9gNl9h9ERSyeRheev10BXBL0ccf/9DOT7ugl8NVLEdBP owxp4u590UZU7v5RLQm37/ez3kF6aKsZ8ZoYpOgj0HKW6HrLx2mdC+8bo1haYyi1 OC60qdLVyRaQic5vDfp2G+P7xqRyKlm63Vu9VwfMXebDDGZKe3wP3JMA/WOpIDMX QUutP8TqLmYMzyQox6F8zhKKoyRKLCH8WLLjHGCNoUpSJjI11a4= =OVbq -----END PGP SIGNATURE----- --xyrouxunwsmlcbyd--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20181004122221.rz5b2qlp6xqucjbu>