From owner-svn-src-head@freebsd.org Fri May 27 14:43:54 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3D78FB4B852; Fri, 27 May 2016 14:43:54 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1C8D4172F; Fri, 27 May 2016 14:43:54 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 38FD4B96E; Fri, 27 May 2016 10:43:53 -0400 (EDT) From: John Baldwin To: Ian Lepore Cc: Gleb Smirnoff , Hans Petter Selasky , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r300718 - in head/sys: kern sys Date: Thu, 26 May 2016 16:59:06 -0700 Message-ID: <2813462.S6nu4flFOa@ralph.baldwin.cx> User-Agent: KMail/4.14.3 (FreeBSD/10.2-STABLE; KDE/4.14.3; amd64; ; ) In-Reply-To: <1464303288.1204.65.camel@freebsd.org> References: <201605260841.u4Q8ft9r045564@repo.freebsd.org> <20160526213716.GK58287@FreeBSD.org> <1464303288.1204.65.camel@freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Fri, 27 May 2016 10:43:53 -0400 (EDT) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 May 2016 14:43:54 -0000 On Thursday, May 26, 2016 04:54:48 PM Ian Lepore wrote: > On Thu, 2016-05-26 at 14:37 -0700, Gleb Smirnoff wrote: > > Hans, > > > > On Thu, May 26, 2016 at 08:41:55AM +0000, Hans Petter Selasky wrote: > > H> Author: hselasky > > H> Date: Thu May 26 08:41:55 2016 > > H> New Revision: 300718 > > H> URL: https://svnweb.freebsd.org/changeset/base/300718 > > H> > > H> Log: > > H> Add support for boolean sysctl's. > > H> > > H> Because the size of bool can be implementation defined, make a > > bool > > H> sysctl handler which handle bools. Userspace sees the bools like > > H> unsigned 8-bit integers. Values are filtered to either 1 or 0 > > upon > > H> read and write, similar to what a compiler would do. > > H> > > H> Requested by: kmacy @ > > H> Sponsored by: Mellanox Technologies > > > > Would be nice if sysctl(8) would explicitly display them as "true" or > > "false" > > instead of 0 and 1. Now the userland can't differ them from uint8_t > > oids. > > If it displayed them that way, then users would want to set them using > the true/false strings too. If you start down that path you eventually > end up adding support for 0/1/true/false/yes/no/on/off, and if you > don't do that in exactly once place you end up with some oids accepting > all the values and others accepting only some of them, and the user > experience is confusing at best. You would just do that parsing in sysctl(8) itself, not in the handlers, so I think it would just be done in one place. -- John Baldwin