From owner-freebsd-current@FreeBSD.ORG Wed Nov 19 21:55:08 2014 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D26AFDEF; Wed, 19 Nov 2014 21:55:08 +0000 (UTC) Received: from mail-yh0-x22c.google.com (mail-yh0-x22c.google.com [IPv6:2607:f8b0:4002:c01::22c]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8C871BC9; Wed, 19 Nov 2014 21:55:08 +0000 (UTC) Received: by mail-yh0-f44.google.com with SMTP id c41so732177yho.31 for ; Wed, 19 Nov 2014 13:55:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=PvbXOsc6Gaqs4Fs6fLpqNEWqteL35nmtailwmeeGqNw=; b=Fb4SPBhkuo1QM5XihftWNmqo+AdL7i2ErYLyqxHfK9x/DyTDPPT+d4zpCqzGukzp+y h4v8+RyTBS88RBBbz0oQJbUZpOEpqYbdjMEYPoZJ2MjxA2XcKK5/pspdqj3eCaoVA5uU u117EYQTLGQ5nEz8IoP6lHNwSFiKCNKpcdjxYB6wIzGmi31jjoan1wBMV73au8wE+c+I 8w3IiLSP4A0wWrpvdWfqiNr8NCfkegn8pY8kkwb1fg7JteKtGzB+BIU5DzkTV+//Tm16 l2BTAuqns/rvpSI++RwKc/4Jo3cPS+X9VQevJ/099Dh6B7/AlMRJ+Mynzbo/VQkwdbyT PVrg== MIME-Version: 1.0 X-Received: by 10.170.233.6 with SMTP id z6mr14156329ykf.101.1416434107742; Wed, 19 Nov 2014 13:55:07 -0800 (PST) Sender: kmacybsd@gmail.com Received: by 10.170.82.197 with HTTP; Wed, 19 Nov 2014 13:55:07 -0800 (PST) In-Reply-To: <546D0CE3.602@selasky.org> References: <546CE948.2070105@selasky.org> <546D0CE3.602@selasky.org> Date: Wed, 19 Nov 2014 13:55:07 -0800 X-Google-Sender-Auth: ifaGTCfY3uro9K_aoZBdgaZU7eg Message-ID: Subject: Re: [RFC] Removal of M_FLOWID flag from m_flags [WAS: Add support for hardware transmit rate limiting queues] From: "K. Macy" To: Hans Petter Selasky Content-Type: text/plain; charset=UTF-8 Cc: Lawrence Stewart , Adrian Chadd , FreeBSD Current , Luigi Rizzo , Navdeep Parhar X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Nov 2014 21:55:08 -0000 On Wed, Nov 19, 2014 at 1:34 PM, Hans Petter Selasky wrote: > On 11/19/14 21:46, K. Macy wrote: >> >> Hi Hans, >> >> It mostly looks fine, but it's a large change and there are some >> places in the patch where it isn't clear that the right thing is being >> done by looking at the patch alone. Please give us some time to >> review. >> > > No problem. Do you think you need more than a week? (Didn't CC the others last time) I probably won't. But I speak only for myself. However, I don't think it's fair to ask you to wait more than two. I've been on the other end of that too many times myself. -K