From owner-svn-ports-all@freebsd.org Wed Feb 12 09:34:06 2020 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 90BE4232BCB; Wed, 12 Feb 2020 09:34:06 +0000 (UTC) (envelope-from pkubaj@anongoth.pl) Received: from mail.anongoth.pl (mail.anongoth.pl [46.248.190.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "anongoth.pl", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48HZGP3Ppxz48Ll; Wed, 12 Feb 2020 09:34:05 +0000 (UTC) (envelope-from pkubaj@anongoth.pl) Received: from anongoth.pl (unknown [192.168.1.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: pkubaj@anongoth.pl) by mail.anongoth.pl (Postfix) with ESMTPSA id 05A164EAC9; Wed, 12 Feb 2020 10:33:55 +0100 (CET) Date: Wed, 12 Feb 2020 10:33:54 +0100 From: Piotr Kubaj To: Gerald Pfeifer Cc: powerpc@freebsd.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r525704 - head/math/hmat-oss Message-ID: <20200212093354.GA81619@KGPE-D16> References: <202002101323.01ADNuln021504@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vkogqOf2sHV7VnPd" Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 48HZGP3Ppxz48Ll X-Spamd-Bar: ------- X-Spamd-Result: default: False [-7.27 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:46.248.190.61]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; IP_SCORE(-2.87)[ip: (-9.91), ipnet: 46.248.160.0/19(-4.81), asn: 47544(0.30), country: PL(0.06)]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DMARC_POLICY_ALLOW(-0.50)[anongoth.pl,reject]; SIGNED_PGP(-2.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MID_RHS_NOT_FQDN(0.50)[]; ASN(0.00)[asn:47544, ipnet:46.248.160.0/19, country:PL]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Feb 2020 09:34:06 -0000 --vkogqOf2sHV7VnPd Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable The only supported FreeBSD version that doesn't support OpenMP is 12.0 with= Clang and it's soon going EOL. This means that all supported releases will soon have OpenMP supported by b= ase compiler (either by GCC or Clang) and USES=3Dcompiler:openmp may then b= e removed. All occurences of: .if ${CHOSEN_COMPILER_TYPE} =3D=3D gcc USE_GC= C=3Dyes should then be converted to just USES=3Dcompiler:c11. So IMO there's little point in your change now that 12.0 EOL is in over 2 w= eeks. On 20-02-12 01:01:25, Gerald Pfeifer wrote: > [ adding powerpc@ ] >=20 > On Mon, 10 Feb 2020, Piotr Kubaj wrote: > > Log: > > math/hmat-oss: fix build on GCC architectures > > =20 > > After OpenBLAS update, new GCC is required: > > CMake Error at /usr/local/share/cmake/Modules/FindPackageHandleStanda= rdArgs.cmake:146 (message): > > Could NOT find CBLAS (missing: CBLAS_LIBRARIES) > : > > +.if ${CHOSEN_COMPILER_TYPE} =3D=3D gcc > > +USE_GCC=3D yes > > +.endif >=20 > This made me realize something bizarre: Mk/Uses/compiler.mk has >=20 > .if ${_COMPILER_ARGS:Mopenmp} > .if ${COMPILER_TYPE} =3D=3D clang =20 > USE_GCC=3D yes > CHOSEN_COMPILER_TYPE=3D gcc > .endif > .endif >=20 > If I read this correctly, on platforms with GCC as the system compiler=20 > this means the rotten GCC 4.2 is used for something new and evolving=20 > like OpenMP? >=20 > Really, OpenMP should imply USE_GCC=3Dyes instead of even trying to > rely on GCC 4.2. That would save you the effort of having to make=20 > such changes one by one and also simplify the ports tree. >=20 > *And* it would align powerpc* more closely with i386/amd64 by using > the same compiler for such ports. >=20 > I'll be happy to prepare a patch for Mk/Uses/compiler.mk, but we'd > need you (and/or other powerpc* folks) to give it a try and adjust > things if necessary. Would you like to? >=20 > Gerald --vkogqOf2sHV7VnPd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAl5DxoEACgkQelmbhSCD nJ2ybw//e1KPfz51AMMO4sq+IzAIen81iNTqWnbIgqo08J3f6p1eG9YuCRSep31K yfZjbzx6Q7bhGeWOhYVWWhwaHDX2R8KiS5vJqpMtQETxA0YKk64nZdKxE8SYp/WY LkuVmfZUnhVi4BDqCIGhzoxgXzUhVLnfYK1wisx4gMfVdrsG5gXtCDrcRE4fW70L iupwl7Qf3pDvDO30SYPnZnhH6HQxS5mgC7R53lOaTaxALwCl5NbmF/pwkFYw/cKO CuRLi5MrSHT/yQhcPyGJT0XRK5LaDXdtVcmnAB1e93YGMNkgixscczZE4tYZzXhf 0gCRfZ6/GDtV/lyZtxEmLZdbxXvAoIPcyi3vCTkYEfcKDHVM4MBpzIEzNNbiD35Y d/3m7RHWlSadeMaMD39YedC9agYOXkZ67f7IQT3PxHRZLSd39t0KpsQEO3CBVYzB dxPBJiKHKY3Q8NHkwFFQJSiwS8kiwjiSDWHZDSg9rDDhgjVxX8y2bo3BqX3nBaaY buD9pnwTfD44AyS9hVl+PdtOyvMpIHAYTHGx14KQwX8FMK+jqA5rV4K6aZNSek3/ FdyFphQE/6yElscDMlFtGHnPrrzWW3Ckx5IxW7/ksGwCoaxVaPvriQ+IybMGNoIL AoFJZpCT/ruivFtE6HCU/OhYoB0BzkjvSXq5JIjAOV+bQq7oMmk= =PMoA -----END PGP SIGNATURE----- --vkogqOf2sHV7VnPd--