From owner-cvs-all Mon Jun 10 0:14:18 2002 Delivered-To: cvs-all@freebsd.org Received: from cs.rice.edu (cs.rice.edu [128.42.1.30]) by hub.freebsd.org (Postfix) with ESMTP id 4456337B407; Mon, 10 Jun 2002 00:14:12 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by cs.rice.edu (Postfix) with ESMTP id 9098C4AA2A; Mon, 10 Jun 2002 02:14:11 -0500 (CDT) Received: by cs.rice.edu (Postfix, from userid 19572) id 1CDB44A9D3; Mon, 10 Jun 2002 02:14:11 -0500 (CDT) Date: Mon, 10 Jun 2002 02:14:11 -0500 From: Alan Cox To: Alfred Perlstein Cc: Alan Cox , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/vm vm_map.c Message-ID: <20020610071411.GL17003@cs.rice.edu> References: <200206100611.g5A6BkG16910@freefall.freebsd.org> <20020610061849.GI88163@elvis.mu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020610061849.GI88163@elvis.mu.org> User-Agent: Mutt/1.3.28i X-Virus-Scanned: by AMaViS snapshot-20010714 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sun, Jun 09, 2002 at 11:18:49PM -0700, Alfred Perlstein wrote: > * Alan Cox [020609 23:12] wrote: > > alc 2002/06/09 23:11:46 PDT > > > > Modified files: > > sys/vm vm_map.c > > Log: > > o In vm_map_entry_create(), call uma_zalloc() with M_NOWAIT on system maps. > > Submitted by: tegge > > Are you sure that is correct? Shouldn't we just propogate the WAIT > flag down from the higher level allocation rather than _always_ > doing a NOWAIT allocation? > Yes, as sure as I (and Tor) can be. Allocation of map entries for system maps should never be allowed to block. This is not a new rule. Prior to the UMA conversion, we had: zinitna(kmapentzone, &kmapentobj, NULL, 0, cnt.v_page_count / 4, ZONE_INTERRUPT, 1); ^^^^^^^^^^^^^^ Alan To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message