Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 20 May 2009 18:38:23 +0200 (CEST)
From:      Stefan Bethke <stb@lassitu.de>
To:        FreeBSD-gnats-submit@FreeBSD.org
Subject:   ports/134758: [patch] graphics/pngnq: fix build
Message-ID:  <200905201638.n4KGcNWU042557@koef.zs64.net>
Resent-Message-ID: <200905201640.n4KGe3LY010454@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         134758
>Category:       ports
>Synopsis:       [patch] graphics/pngnq: fix build
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Wed May 20 16:40:03 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     Stefan Bethke
>Release:        FreeBSD 8.0-CURRENT amd64
>Organization:
>Environment:
System: FreeBSD koef.zs64.net 8.0-CURRENT FreeBSD 8.0-CURRENT #8: Thu Feb 12 21:42:10 UTC 2009 root@lokschuppen.lassitu.de:/usr/obj/usr/src/sys/EISENBOOT amd64
>Description:

CFLAGS hat wrong quoting for the version number, resulting in a segfault on
invocation of pngnq -V.

>How-To-Repeat:
>Fix:
diff -u Makefile.orig Makefile
--- Makefile.orig	2009-05-11 00:37:04.000000000 +0200
+++ Makefile	2009-05-20 18:30:09.979798772 +0200
@@ -7,6 +7,7 @@
 
 PORTNAME=	pngnq
 PORTVERSION=	0.5
+PORTREVISION=	1
 CATEGORIES=	graphics
 MASTER_SITES=	SF
 DISTNAME=	${PORTNAME}-${PORTVERSION}-src
@@ -19,7 +20,7 @@
 WRKSRC=		${WRKDIR}/${PORTVERSION}
 
 USE_GMAKE=	yes
-MAKE_ARGS=	CC="${CC}" CFLAGS="${CFLAGS} -I${LOCALBASE}/include -DVERSION='${PORTVERSION}'" \
+MAKE_ARGS=	CC="${CC}" CFLAGS="${CFLAGS} -I${LOCALBASE}/include -DVERSION='\"${PORTVERSION}\"'" \
 		LDFLAGS="-lpng -lz -lm -L${LOCALBASE}/lib"
 
 PORTDOCS=	README LICENSE README.pngcomp
>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200905201638.n4KGcNWU042557>