From nobody Sat May 6 00:26:53 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QCpK11DZJz4B0XF; Sat, 6 May 2023 00:27:01 +0000 (UTC) (envelope-from peterj@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QCpK10lfYz417c; Sat, 6 May 2023 00:27:01 +0000 (UTC) (envelope-from peterj@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1683332821; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=M+nDiOb47LO4iim4Y+HmyS4Wfh72R6QYgv9fahDybuA=; b=BnuK32+8dm9qqyKaVlSj1bjxhniFnvCqmP+NRi0SJ9Ktq2/K782Aalv8FshMTpIv8Xk50t ZDMI80rfLGw8r249RZKVRNzhXi44rpVrKmrBZKNxxKJ7wKGgsWs3iYOUFhKNHVhMHfRI+h /Ol4rpQ8QQXF44ICgFv6zrmy9hC5hyjWPnsUkam+KdlWubC6HyKDr11TMHfeUge8K6YWti lefrqyJdjFX86ZcfGMapcRwokJR8BF0IPfAn0vCxkkk42IaWRsVVS4HohpIycHHUBLalAn HwKZrFq/d6L4WXrsT0Cy3haBH3kUHjx7f1vvnP4O+eHkHjxghtCyaqXdxqsL0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1683332821; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=M+nDiOb47LO4iim4Y+HmyS4Wfh72R6QYgv9fahDybuA=; b=sKPaTI3gKV/XMU8tMEcGuh0OuJC+veS+tkh/oA+L2XCOCTNA/mK2mkPcQnVE+DpGGUeS49 Bi19ZXnTnsNiD1tmHCPa9JS1MBwMFnFOjj07yP5vHlMUzLylynH2ocSk4oHOn4kXEXGaFh OL+ZfzGW04JrgfIkhw5eSPWbnuJpaNyF91IjNktXvAwh97NrXeZSwlutfjb/DNXoxBPMFS cmTWcj3Ceblq6c2/EnAfNX7zj0tLbzeER8UcpmNwxrNnhn+ZA1IK3pZCMKUTGjlSOxoDRS RG6KaAVRywIqOivW+sveclTMRAb96ZSVPWsACrECsMQ6TqtqjwK1DXqXY2C2pw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1683332821; a=rsa-sha256; cv=none; b=vlo5R3p3y+oZS4zb+7lmeHWFJkPtgVEWBLCT02KCWMy6HCARfKw1+i2w5H7l7uNKVRNVkq 7agNpygGS2dkB0TeXGxU7/AHdxeRsQ0kejq7kXJ8ulDrf58WUv14aPV5T+UUR5MkE5kqi3 jYkhVR8AUgcROKWQY57kG+Hm80RzTF84H+10qdPRU71khUpE76HPmBTOXyY0BL5Ipou8YS gOOcfnYC8xgvTLpavCbxa6HnaX0RxjZ812xgNBh9RP+alZq33hutpALszZQ5NkzAjMRVGh aAb1qsD86qDJMxL2xGsfN9OKPfvolOx3dETjElSww3B05eCZWKKCT30KaiWsHA== Received: from server.rulingia.com (ppp239-208.static.internode.on.net [59.167.239.208]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA512) (Client did not present a certificate) (Authenticated sender: peterj) by smtp.freebsd.org (Postfix) with ESMTPSA id 4QCpJz46lPzd1v; Sat, 6 May 2023 00:26:59 +0000 (UTC) (envelope-from peterj@freebsd.org) Date: Sat, 6 May 2023 10:26:53 +1000 From: Peter Jeremy To: Konstantin Belousov Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 42f722e721cd - main - amd64: store pcids pmap data in pcpu zone Message-ID: References: <202305021139.342Bdtn7092368@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="CB/PyJuI29xUfjOc" Content-Disposition: inline In-Reply-To: <202305021139.342Bdtn7092368@gitrepo.freebsd.org> X-PGP-Key: http://www.rulingia.com/keys/peter.pgp X-ThisMailContainsUnwantedMimeParts: N --CB/PyJuI29xUfjOc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2023-May-02 11:39:55 +0000, Konstantin Belousov wrote: >The branch main has been updated by kib: > >URL: https://cgit.FreeBSD.org/src/commit/?id=3D42f722e721cd010ae5759a4b0d3= b7b93c2b9cad2 > >commit 42f722e721cd010ae5759a4b0d3b7b93c2b9cad2 >Author: Konstantin Belousov >AuthorDate: 2023-05-01 05:17:45 +0000 >Commit: Konstantin Belousov >CommitDate: 2023-05-02 11:32:47 +0000 > > amd64: store pcids pmap data in pcpu zone > =20 > This change eliminates the struct pmap_pcid array embedded into struct > pmap and sized by MAXCPU, which would bloat with MAXCPU increase. Also > it removes false sharing of cache lines, since the array elements are > mostly locally accessed by corresponding CPUs. > =20 > Suggested by: mjg > Reviewed by: markj > Tested by: pho > Sponsored by: The FreeBSD Foundation > Differential revision: https://reviews.freebsd.org/D39890 This breaks the !SMP case: Whilst references to pm_pcids have been replaced in the SMP case, there are still references to pmap->pm_pcids[0] in the !SMP cane. --=20 Peter Jeremy --CB/PyJuI29xUfjOc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKSBAEBCgB9FiEE7rKYbDBnHnTmXCJ+FqWXoOSiCzQFAmRVnshfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEVF QjI5ODZDMzA2NzFFNzRFNjVDMjI3RTE2QTU5N0EwRTRBMjBCMzQACgkQFqWXoOSi CzSPpw/4g+r2OztXiYuzQzfT+LhGLrPYSxS/RYx/OlTVSVuA2dAZUDbplKIj7gQ5 lRNjmgbLQK4nRTcmNhpJFJbrut34ALzhGOg8bOA7pmOlncBXwMFX4TKL3I3xMuaJ z0ivHEEWRvvbdSm03+QuyTUzjSfqcpj3aQzOwSzyZaKxDQB2pPC5L0j/AgNW9Qgl 61j/6tvlDD4oPldkEzO2iIprKGFhmjgQWUs8qL1xz3F171T8UKK5COd2uskQJC7H mGaxb814vg35KnbVecC+xYOEPjylQehb2bWnC630fXDV/tfvJZNAMFzVY2/BNUuf mw+IaSAvqhz4TIfcV82y4tVju9MH1b7s7EZpQiugyq3sA1wMMe1kwHyV5AThM3HR VecL0j8Ie4EisSmur8fdkr1c36ZXcXaO5u6moNixhhyzyFahNaQlXXck5GNdqtp4 fWmzJ4Q0XAWqUgoFEkE1y2zGoweZl/057s8HPwfJEYk6mitXCCCsD/BV68d2r9sB iPFeVIa8F/7cZOEZ8ADG/9fKvI9CasiqOoe9EZJcEzFamXtSF8JvWGAkJN78TEew iZupOzXR8x5kjhu5sCxEA0xnSHqzfyclxZzL8/3R5UkJ4iChcrpk3bQOzDwwt5q3 s6fzqT5GfwVauXCZqdTSavEv+D/G+6iv8lDyDdfG9YZdvcce5A== =Co19 -----END PGP SIGNATURE----- --CB/PyJuI29xUfjOc--