Date: Sat, 6 May 2023 10:26:53 +1000 From: Peter Jeremy <peterj@freebsd.org> To: Konstantin Belousov <kib@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 42f722e721cd - main - amd64: store pcids pmap data in pcpu zone Message-ID: <ZFWezZWfC_TmuYCG@server.rulingia.com> In-Reply-To: <202305021139.342Bdtn7092368@gitrepo.freebsd.org> References: <202305021139.342Bdtn7092368@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--CB/PyJuI29xUfjOc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2023-May-02 11:39:55 +0000, Konstantin Belousov <kib@FreeBSD.org> wrote: >The branch main has been updated by kib: > >URL: https://cgit.FreeBSD.org/src/commit/?id=3D42f722e721cd010ae5759a4b0d3= b7b93c2b9cad2 > >commit 42f722e721cd010ae5759a4b0d3b7b93c2b9cad2 >Author: Konstantin Belousov <kib@FreeBSD.org> >AuthorDate: 2023-05-01 05:17:45 +0000 >Commit: Konstantin Belousov <kib@FreeBSD.org> >CommitDate: 2023-05-02 11:32:47 +0000 > > amd64: store pcids pmap data in pcpu zone > =20 > This change eliminates the struct pmap_pcid array embedded into struct > pmap and sized by MAXCPU, which would bloat with MAXCPU increase. Also > it removes false sharing of cache lines, since the array elements are > mostly locally accessed by corresponding CPUs. > =20 > Suggested by: mjg > Reviewed by: markj > Tested by: pho > Sponsored by: The FreeBSD Foundation > Differential revision: https://reviews.freebsd.org/D39890 This breaks the !SMP case: Whilst references to pm_pcids have been replaced in the SMP case, there are still references to pmap->pm_pcids[0] in the !SMP cane. --=20 Peter Jeremy --CB/PyJuI29xUfjOc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKSBAEBCgB9FiEE7rKYbDBnHnTmXCJ+FqWXoOSiCzQFAmRVnshfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEVF QjI5ODZDMzA2NzFFNzRFNjVDMjI3RTE2QTU5N0EwRTRBMjBCMzQACgkQFqWXoOSi CzSPpw/4g+r2OztXiYuzQzfT+LhGLrPYSxS/RYx/OlTVSVuA2dAZUDbplKIj7gQ5 lRNjmgbLQK4nRTcmNhpJFJbrut34ALzhGOg8bOA7pmOlncBXwMFX4TKL3I3xMuaJ z0ivHEEWRvvbdSm03+QuyTUzjSfqcpj3aQzOwSzyZaKxDQB2pPC5L0j/AgNW9Qgl 61j/6tvlDD4oPldkEzO2iIprKGFhmjgQWUs8qL1xz3F171T8UKK5COd2uskQJC7H mGaxb814vg35KnbVecC+xYOEPjylQehb2bWnC630fXDV/tfvJZNAMFzVY2/BNUuf mw+IaSAvqhz4TIfcV82y4tVju9MH1b7s7EZpQiugyq3sA1wMMe1kwHyV5AThM3HR VecL0j8Ie4EisSmur8fdkr1c36ZXcXaO5u6moNixhhyzyFahNaQlXXck5GNdqtp4 fWmzJ4Q0XAWqUgoFEkE1y2zGoweZl/057s8HPwfJEYk6mitXCCCsD/BV68d2r9sB iPFeVIa8F/7cZOEZ8ADG/9fKvI9CasiqOoe9EZJcEzFamXtSF8JvWGAkJN78TEew iZupOzXR8x5kjhu5sCxEA0xnSHqzfyclxZzL8/3R5UkJ4iChcrpk3bQOzDwwt5q3 s6fzqT5GfwVauXCZqdTSavEv+D/G+6iv8lDyDdfG9YZdvcce5A== =Co19 -----END PGP SIGNATURE----- --CB/PyJuI29xUfjOc--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ZFWezZWfC_TmuYCG>