From owner-freebsd-gnome  Sat Jan 19  8:51:11 2002
Delivered-To: freebsd-gnome@freebsd.org
Received: from creme-brulee.marcuscom.com (rdu57-28-046.nc.rr.com [66.57.28.46])
	by hub.freebsd.org (Postfix) with ESMTP id 15A3837B400
	for <gnome@FreeBSD.ORG>; Sat, 19 Jan 2002 08:51:08 -0800 (PST)
Received: from shumai.marcuscom.com (marcus@shumai.marcuscom.com [192.168.1.4])
	by creme-brulee.marcuscom.com (8.11.6/8.11.6) with ESMTP id g0JGoQZ46149;
	Sat, 19 Jan 2002 11:50:26 -0500 (EST)
	(envelope-from marcus@marcuscom.com)
Subject: Re: deskutils/gnomepim
From: Joe Clarke <marcus@marcuscom.com>
To: Anders Andersson <anders@hack.org>
Cc: gnome@FreeBSD.ORG
In-Reply-To: <20020119164923.GC20216@sushi.sanyusan.se>
References: <20020119162813.GA25897@sushi.sanyusan.se>
	<1011458564.62255.3.camel@shumai.marcuscom.com> 
	<20020119164923.GC20216@sushi.sanyusan.se>
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
X-Mailer: Evolution/1.0.1 
Date: 19 Jan 2002 11:51:13 -0500
Message-Id: <1011459073.62255.5.camel@shumai.marcuscom.com>
Mime-Version: 1.0
Sender: owner-freebsd-gnome@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-gnome.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-gnome>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-gnome>
X-Loop: FreeBSD.ORG

On Sat, 2002-01-19 at 11:49, Anders Andersson wrote:
> On Sat, Jan 19, 2002 at 11:42:43AM -0500, Joe Clarke wrote:
> > On Sat, 2002-01-19 at 11:28, Anders Andersson wrote:
> > > It seems that the expected result is inverted in gnomepim's Makefile.
> > > 
> > > If I define WITHOUT_PILOT then it builds gnomepim with pilot support and
> > > if I dont define WITHOUT_PILOT it happily builds without pilot-link and
> > > so on.
> > > 
> > > I will look at the Makefile to see if I have missed a studpid tweak or
> > > not.
> > 
> > You're absolutely right.  The Makefile should read:
> > 
> > .if !defined(WITHOUT_PILOT)
> > BUILD_DEPENDS= 
> > ${X11BASE}/lib/gnome-pilot/conduits/libemail_conduit.so:${PORTSDIR}/palm/gnomepilot-conduits
> > RUN_DEPENDS=   
> > ${X11BASE}/lib/gnome-pilot/conduits/libemail_conduit.so:${PORTSDIR}/palm/gnomepilot-conduits
> > .endif
> > 
> > But instead will add the depends when you _do_ define WITHOUT_PILOT.  Of
> > course, it goes on to do the right thing in other places, so this may
> > break the port.
> > 
> > The attached patch should fix things.
> 
> Hah, I cant belive I missed that '!' 
> 
> I will try this and report back if I find any problems.

The build will still fail since it looks like gnomepim ignores
--without-pisock.  I'm looking at it now.

Joe

> -- 
> Anders Andersson <anders@hack.org>
> UNIX, Networking and Security consultant
> +46 (0)705 87 53 35
> 



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-gnome" in the body of the message