From owner-freebsd-stable@FreeBSD.ORG Thu Aug 2 20:28:29 2012 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 79919106566C; Thu, 2 Aug 2012 20:28:29 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-lb0-f182.google.com (mail-lb0-f182.google.com [209.85.217.182]) by mx1.freebsd.org (Postfix) with ESMTP id 433678FC18; Thu, 2 Aug 2012 20:28:27 +0000 (UTC) Received: by lbbgm13 with SMTP id gm13so1110108lbb.13 for ; Thu, 02 Aug 2012 13:28:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=B8y0MklcVeV53LDJXW8poIPDjHdgScis5oZHlsOPTjA=; b=gSSQVqySDL7QfmNDCvlcAmXUqJcRwYJzXabbj5gPOoRh9N/meuDIZEcYwxaRkTphqC Odd5wAyXGMV5uDnfkM+5A4V/YbeOtbRpnW93xvZQMFr5Mt2yYY/ehNdcRB+y9UdhA3h8 mTimbkaLV76o6L8vvsdxGxGTxegrBq2p48JVh8uvH7vxZ7uH7fTiantRR7yti5QkPntF tOnVe+bop+8LoGudCDYOQog4jfJrQFUrOv3v/7JT5E8AoyRc18X860S6j0/iJZdp74HZ KLSxmRVzWUvX9VOJdeJrroPSUbY0hOfVm5mG05fTs/llTyGgWFa465Xfs+qFvvw/7CrS s5FA== MIME-Version: 1.0 Received: by 10.152.144.163 with SMTP id sn3mr15324050lab.37.1343939306992; Thu, 02 Aug 2012 13:28:26 -0700 (PDT) Sender: asmrookie@gmail.com Received: by 10.112.27.65 with HTTP; Thu, 2 Aug 2012 13:28:26 -0700 (PDT) In-Reply-To: <201208020951.19565.jhb@freebsd.org> References: <1342742294.2656.24.camel@powernoodle.corp.yahoo.com> <201208010853.11447.jhb@freebsd.org> <1343861328.5229.6.camel@powernoodle.corp.yahoo.com> <201208020951.19565.jhb@freebsd.org> Date: Thu, 2 Aug 2012 21:28:26 +0100 X-Google-Sender-Auth: 456hHDR_UimVgZ_iBTCY6bpsdfA Message-ID: From: Attilio Rao To: John Baldwin Content-Type: text/plain; charset=UTF-8 Cc: "freebsd-stable@freebsd.org" , Sean Bruno Subject: Re: [stable 9] panic on reboot: ipmi_wd_event() X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: attilio@FreeBSD.org List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Aug 2012 20:28:29 -0000 On 8/2/12, John Baldwin wrote: > On Wednesday, August 01, 2012 6:48:48 pm Sean Bruno wrote: >> On Wed, 2012-08-01 at 05:53 -0700, John Baldwin wrote: >> > Index: vfs_subr.c >> > =================================================================== >> > --- vfs_subr.c (revision 238969) >> > +++ vfs_subr.c (working copy) >> > @@ -1868,8 +1868,11 @@ sched_sync(void) >> > continue; >> > } >> > >> > - if (first_printf == 0) >> > + if (first_printf == 0) { >> > + mtx_unlock(&sync_mtx); >> > wdog_kern_pat(WD_LASTVAL); >> > + mtx_lock(&sync_mtx); >> > + } >> > >> > } >> > if (!LIST_EMPTY(gslp)) { >> > >> > >> > -- >> > John Baldwin >> >> This definitely makes the panic go away on reboot. > > Attilio, does this change seem ok to you? Thanks for asking me to review. I think it is safe because we are going to use LIST_EMPTY() on the global list anyway as next check. Attilio -- Peace can only be achieved by understanding - A. Einstein