From owner-svn-src-projects@FreeBSD.ORG  Tue Jan 27 19:34:23 2015
Return-Path: <owner-svn-src-projects@FreeBSD.ORG>
Delivered-To: svn-src-projects@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 537FB9B9;
 Tue, 27 Jan 2015 19:34:23 +0000 (UTC)
Received: from mail-wg0-x233.google.com (mail-wg0-x233.google.com
 [IPv6:2a00:1450:400c:c00::233])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id DAE7EAE9;
 Tue, 27 Jan 2015 19:34:22 +0000 (UTC)
Received: by mail-wg0-f51.google.com with SMTP id k14so16603992wgh.10;
 Tue, 27 Jan 2015 11:34:21 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=MbHQp/uoKT7EA3IChl6a9FM7fbt8a1jrp0xsLy7yrrs=;
 b=w1NbX3Nq482OlDP9/UB41miBgfqau3zFT+THeTjfIfSppDnT6oqklUQeWit0W5IUek
 gJL9uRhHUgdzBxAzh4hJrl8msUBTeTUkCAHXPwuc4Xt0W/lGJfxYyrcnOD4QUzPhSbxN
 +sXNUJ1Fs3ecet8tSgiPcmenibhf9gSS8OMPx1wNffea3Bx2AxWg02qw4kx/BVBJEfrR
 iJYXEijc3qRHRT63F6beEktz5aPpKHAXazP8mRrN1SXbQDi7bucKsJzorYtvRzrO5V6m
 C9ZjrasIN6hDWgRbtaq8zPeyvFQLNW07Lobe5RL0e3a0ve6rMfv2KgmcPyBNaj/NUjT4
 S6tg==
MIME-Version: 1.0
X-Received: by 10.194.60.77 with SMTP id f13mr5748710wjr.105.1422387261189;
 Tue, 27 Jan 2015 11:34:21 -0800 (PST)
Received: by 10.27.77.141 with HTTP; Tue, 27 Jan 2015 11:34:21 -0800 (PST)
In-Reply-To: <201501271925.t0RJPem3010417@svn.freebsd.org>
References: <201501271925.t0RJPem3010417@svn.freebsd.org>
Date: Tue, 27 Jan 2015 14:34:21 -0500
Message-ID: <CAJ5_RoAvww7xFsSTBMPDThYsbpVbxOs11nWE=eEXpJRFx_kyww@mail.gmail.com>
Subject: Re: svn commit: r277803 - projects/clang360-import/lib/clang/include
From: Benjamin Kaduk <bjkfbsd@gmail.com>
To: Dimitry Andric <dim@freebsd.org>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1
Cc: svn-src-projects@freebsd.org,
 "src-committers@freebsd.org" <src-committers@freebsd.org>
X-BeenThere: svn-src-projects@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the src &quot; projects&quot;
 tree" <svn-src-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-projects>, 
 <mailto:svn-src-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-projects/>
List-Post: <mailto:svn-src-projects@freebsd.org>
List-Help: <mailto:svn-src-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-projects>, 
 <mailto:svn-src-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Jan 2015 19:34:23 -0000

On Tue, Jan 27, 2015 at 2:25 PM, Dimitry Andric <dim@freebsd.org> wrote:

> Author: dim
> Date: Tue Jan 27 19:25:39 2015
> New Revision: 277803
> URL: https://svnweb.freebsd.org/changeset/base/277803
>
> Log:
>   Change the path to clang's private headers.  Upstream has always stored
>   these in $LIBDIR/clang/$VERSION/include, instead of our previous custom
>   location in /usr/include/clang/$VERSION.  This allows us to drop yet
>   another FreeBSD-specific patch.
>
> Modified:
>   projects/clang360-import/lib/clang/include/Makefile
>
> Modified: projects/clang360-import/lib/clang/include/Makefile
>
> ==============================================================================
> --- projects/clang360-import/lib/clang/include/Makefile Tue Jan 27
> 18:58:24 2015        (r277802)
> +++ projects/clang360-import/lib/clang/include/Makefile Tue Jan 27
> 19:25:39 2015        (r277803)
> @@ -8,7 +8,7 @@ LLVM_SRCS= ${.CURDIR}/../../../contrib/l
>
>  .PATH: ${LLVM_SRCS}/tools/clang/lib/Headers
>
> -INCSDIR=${INCLUDEDIR}/clang/3.6.0
> +INCSDIR=/usr/lib/clang/3.6.0/include
>

Is it a good idea to hardcode /usr/lib/ here?

-Ben