From owner-svn-src-stable-10@freebsd.org Wed May 3 17:12:55 2017 Return-Path: Delivered-To: svn-src-stable-10@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C051BD5CE78; Wed, 3 May 2017 17:12:55 +0000 (UTC) (envelope-from ricera10@gmail.com) Received: from mail-io0-f178.google.com (mail-io0-f178.google.com [209.85.223.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 930A9E74; Wed, 3 May 2017 17:12:55 +0000 (UTC) (envelope-from ricera10@gmail.com) Received: by mail-io0-f178.google.com with SMTP id p24so12276642ioi.0; Wed, 03 May 2017 10:12:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EGquDYSRZV3OYwfeOTix+w7Dl12CHaDep/FE23O4LcU=; b=RoxNM01FXe4CIFJhX0yRdXPp/uBuCBAEVcv5JKvo6zzQgK+g/sTZh6cj75RjteXhPs sNcAbQ2a/5vMg7xFt5c2AVq0ZNdRI0tLsGgaNZJoVAec5RbdodENZSBRw1TYcvqd5zso AlEcI3Ax/MnTA4a/8YTKpezFAKT7fPurFIlLVgu52YrmaLiDSKeY1uNwkTswypBR16Oc mQG1/W6RS47zMl0z+XSPs98X3r/wclzjNN19J2SwSA5r+VkovCosORSR90GhSIcd3/Z1 J1BzYtVaYm3CVMqipbnVgWan/8K89W28tAhZdVVoLl2RiIYlKZMxSuNCgaQQ0ppUPfDe Wdvg== X-Gm-Message-State: AN3rC/46pU5O4GKXjRP5Ecu/6v8Qc1+cJYW6mWmEbzYtP+h9Q554qWTl bOP3yHoktedTbeJqLuOwLQ== X-Received: by 10.107.192.71 with SMTP id q68mr19264654iof.119.1493831569323; Wed, 03 May 2017 10:12:49 -0700 (PDT) Received: from mail-it0-f54.google.com (mail-it0-f54.google.com. [209.85.214.54]) by smtp.gmail.com with ESMTPSA id z85sm3104438ita.3.2017.05.03.10.12.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 May 2017 10:12:49 -0700 (PDT) Received: by mail-it0-f54.google.com with SMTP id c15so74301706ith.0; Wed, 03 May 2017 10:12:48 -0700 (PDT) X-Received: by 10.202.220.213 with SMTP id t204mr12458633oig.193.1493831568395; Wed, 03 May 2017 10:12:48 -0700 (PDT) MIME-Version: 1.0 References: <201703152120.v2FLKHUs052999@repo.freebsd.org> In-Reply-To: From: Eric Joyner Date: Wed, 03 May 2017 17:12:37 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r315333 - in stable/10/sys: conf dev/ixgbe modules/ix modules/ixv To: Ngie Cooper , Ed Maste Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-stable@freebsd.org" , "svn-src-stable-10@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-stable-10@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for only the 10-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 May 2017 17:12:55 -0000 This fixes the amd64 LINT build error, but not the others. I'm looking at fixing the others now. On Tue, May 2, 2017 at 3:58 PM Eric Joyner wrote: > I fixed the netmap build for amd64 at least with r317711. I'm running a > tinderbox build on it now, though, so I'll see if that fixes it. > > On Fri, Apr 28, 2017 at 1:40 PM Eric Joyner wrote: > >> I notified Jeb (the original patch submitter) about that netmap symbol >> issue, but we've both been distracted with other development. I'll work on >> updating it. >> >> - Eric >> >> On Thu, Apr 27, 2017 at 3:06 PM Ngie Cooper >> wrote: >> >>> On Thu, Apr 27, 2017 at 1:07 PM, Ed Maste wrote: >>> > On 15 March 2017 at 17:20, Eric Joyner wrote: >>> >> Author: erj >>> >> Date: Wed Mar 15 21:20:17 2017 >>> >> New Revision: 315333 >>> >> URL: https://svnweb.freebsd.org/changeset/base/315333 >>> >> >>> >> Log: >>> >> ixgbe(4): Update to 3.2.11-k >>> > >>> > This broke tinderbox on many architectures: >>> > >>> > ia64 GENERIC and powerpc GENERIC64: >>> > >>> > /scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ixv_osdep.c:39: warning: no >>> > previous prototype for 'ixv_read_pci_cfg' [-Wmissing-prototypes] >>> > /scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ixv_osdep.c:45: warning: no >>> > previous prototype for 'ixv_write_pci_cfg' [-Wmissing-prototypes] >>> > >>> > sparc64 LINT: >>> > >>> > /scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ix_txrx.c:43: warning: >>> > redundant redeclaration of 'ix_crcstrip' [-Wredundant-decls] >>> > /scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ixgbe_netmap.h:45: warning: >>> > previous declaration of 'ix_crcstrip' was here >>> > >>> > amd64 LINT: >>> > >>> > /scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ixv_netmap.c:(.text+0x0): >>> > multiple definition of `ixgbe_netmap_attach' >>> > >>> ixgbe_netmap.o:/scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ixgbe_netmap.c:(.text+0x0): >>> > first defined here >>> >>> Hi Ed, >>> >>> It has to do with netmap(4) refactoring on head not being backported, >>> in combination with ixgbe/ix being MFCed in a refactored state back to >>> ^/stable/10 (it wasn't easy to backport due to PCI-IOV only being on >>> ^/stable/10 -- I tried starting this work and failed because I lacked >>> the hardware to test this out with). >>> >>> This has been known to be broken for almost two months -- a surgical >>> fix should probably be applied to do what's required to make the >>> symbol appear in the appropriate places, since this basically was a >>> direct commit to ^/stable/10 in some regards. >>> >>> Thanks, >>> -Ngie >>> >>