From owner-freebsd-net@FreeBSD.ORG Wed Jan 28 08:00:25 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 26CF98CF for ; Wed, 28 Jan 2015 08:00:25 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0476BACE for ; Wed, 28 Jan 2015 08:00:25 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t0S80Ot7086498 for ; Wed, 28 Jan 2015 08:00:24 GMT (envelope-from mat@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t0S80OrV086497; Wed, 28 Jan 2015 08:00:24 GMT (envelope-from mat) Date: Wed, 28 Jan 2015 08:00:24 +0000 To: freebsd-net@freebsd.org From: "arybchik (Andrew Rybchenko)" Subject: [Differential] [Request, 2 lines] D1694: sfxge: Move txq->next pointer to part writable on completion path Message-ID: X-Priority: 3 Thread-Topic: D1694: sfxge: Move txq->next pointer to part writable on completion path X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: Thread-Index: YTIzODBmY2JlMjNhMDRmNDFmNmQzOTU2NTVk X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jan 2015 08:00:25 -0000 arybchik created this revision. arybchik added a reviewer: gnn. arybchik added a subscriber: freebsd-net. REVISION SUMMARY In fact the pointer is used only if more than one TXQ is processed in one interrupt. It is used (read-write) on completion path only. Also it makes the first part of the structure smaller and it fits now into one 128byte cache line. So, TXQ structure becomes 128 bytes smaller. Sponsored by: Solarflare Communications, Inc. BRANCH /head REVISION DETAIL https://reviews.freebsd.org/D1694 AFFECTED FILES sys/dev/sfxge/sfxge_tx.h To: arybchik, gnn Cc: freebsd-net