From owner-svn-src-all@FreeBSD.ORG Tue Oct 8 08:16:18 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 55792F2E; Tue, 8 Oct 2013 08:16:18 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 433442D64; Tue, 8 Oct 2013 08:16:18 +0000 (UTC) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.7/8.14.7) with ESMTP id r988GISE061513; Tue, 8 Oct 2013 08:16:18 GMT (envelope-from glebius@svn.freebsd.org) Received: (from glebius@localhost) by svn.freebsd.org (8.14.7/8.14.5/Submit) id r988GIxn061511; Tue, 8 Oct 2013 08:16:18 GMT (envelope-from glebius@svn.freebsd.org) Message-Id: <201310080816.r988GIxn061511@svn.freebsd.org> From: Gleb Smirnoff Date: Tue, 8 Oct 2013 08:16:18 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r256137 - head/sbin/route X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Oct 2013 08:16:18 -0000 Author: glebius Date: Tue Oct 8 08:16:17 2013 New Revision: 256137 URL: http://svnweb.freebsd.org/changeset/base/256137 Log: When destination parameter is missing, exit with a clear synopsis, instead of writing to kernel and printing EINVAL description. PR: bin/181532 Submitted by: Kurt Jaeger Approved by: re (hrs) Modified: head/sbin/route/route.c Modified: head/sbin/route/route.c ============================================================================== --- head/sbin/route/route.c Tue Oct 8 07:02:23 2013 (r256136) +++ head/sbin/route/route.c Tue Oct 8 08:16:17 2013 (r256137) @@ -928,6 +928,11 @@ newroute(int argc, char **argv) } } + if (so[RTAX_DST].ss_len == 0) { + warnx("destination parameter required"); + usage(NULL); + } + if (nrflags & F_FORCEHOST) { nrflags |= F_ISHOST; #ifdef INET6