From owner-freebsd-arch Fri Mar 23 21:17: 7 2001 Delivered-To: freebsd-arch@freebsd.org Received: from meow.osd.bsdi.com (meow.osd.bsdi.com [204.216.28.88]) by hub.freebsd.org (Postfix) with ESMTP id 4BF9F37B719; Fri, 23 Mar 2001 21:17:05 -0800 (PST) (envelope-from jhb@FreeBSD.org) Received: from laptop.baldwin.cx (john@jhb-laptop.osd.bsdi.com [204.216.28.241]) by meow.osd.bsdi.com (8.11.2/8.11.2) with ESMTP id f2O5GQG36272; Fri, 23 Mar 2001 21:16:26 -0800 (PST) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: Date: Fri, 23 Mar 2001 21:16:37 -0800 (PST) From: John Baldwin To: John Baldwin Subject: Re: Critical Regions Round II Cc: arch@FreeBSD.org, Bruce Evans Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On 24-Mar-01 John Baldwin wrote: >> This was really a renaming of the x86-specific interfaces read_eflags() >> and write_eflags(). I object to the x86 code being changed to use the >> new names. The x86 code that disables interrupts mostly wants precisely >> the MD interfaces, not the MI abstraction of them. It just happens that >> the MI versions are binary-identical with the MD versions. > > Ok, I could go with that. (/me deletes half of his patch.) Actually, I thought about this some more. Most of the places that do this (for example, before setting cr0 or something else critical) don't really care about any of the flags values, they are just keeping from being preempted, so I think that using critical_* in those places is more appropriate. If something needs to read eflags and act on it, then one would use read_eflags(). MD code still calls MI functions in other places. -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message