From owner-svn-src-projects@freebsd.org Thu Sep 17 16:30:14 2015 Return-Path: Delivered-To: svn-src-projects@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E5FE59CEA59 for ; Thu, 17 Sep 2015 16:30:13 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qg0-f43.google.com (mail-qg0-f43.google.com [209.85.192.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A63191337 for ; Thu, 17 Sep 2015 16:30:13 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by qgx61 with SMTP id 61so17142686qgx.3 for ; Thu, 17 Sep 2015 09:30:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=CCfG2rzxTgvJ8mKUod0Kh84yBJWH4bXz9dNvkgj3NBg=; b=lhLqbRVwFBXHT7kIxt+79uISWlkF8/EL6IafFy+5J/G5yNGGraMRWexnhc7d/ZojsY 0eqb4I01wNzUM5yluEzU/grnyww6iWMbDDKiE5zilpyBIsO2FRjsc3ly+6h5slMRJKmv DazAjcNgpUvXCX1Ub3JmmaWBtwSimLwrk6WdsPsV71+w5kjJo/tbln93DcN7Emq3m4ik x/2o4q1pefohzGlOrqBLao8py8xeYnA0c6jQZz7wl/jxIDmMDpWvLoKvyhgcXVtX8Rzk UZFrJ55/cJEV30eEezwxT0li9vF7if+WgsgwUzoH1B1O3cfggcqXhksMOhA2x+zUzAOo mOww== X-Gm-Message-State: ALoCoQkwfEo6JW+SMEXXxTnTy9uP+obl07q1/LfGql9xVN6QhlEcKjKBhlFXSA68smylKRQL6ayA MIME-Version: 1.0 X-Received: by 10.140.164.7 with SMTP id k7mr93427qhk.40.1442507412310; Thu, 17 Sep 2015 09:30:12 -0700 (PDT) Sender: wlosh@bsdimp.com Received: by 10.140.80.167 with HTTP; Thu, 17 Sep 2015 09:30:12 -0700 (PDT) X-Originating-IP: [50.253.99.174] In-Reply-To: <55FAD739.1050800@fastmail.net> References: <201509162215.t8GMFp1b023705@repo.freebsd.org> <55FAB5DD.20609@fastmail.net> <55FAD739.1050800@fastmail.net> Date: Thu, 17 Sep 2015 10:30:12 -0600 X-Google-Sender-Auth: 7Ay_6nCCOoLv8FbPnJtztswSS_o Message-ID: Subject: Re: svn commit: r287876 - in projects/iosched/sys/cam: . ata scsi From: Warner Losh To: Bruce Simpson Cc: Warner Losh , src-committers , svn-src-projects@freebsd.org Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Sep 2015 16:30:14 -0000 On Thu, Sep 17, 2015 at 9:07 AM, Bruce Simpson wrote: > On 17/09/15 15:16, Warner Losh wrote: > >> This isn't even in -current yet, but this will work in 10.x. It's >> dependent, at the moment, >> on the I/O scheduler work I've done in this project branch. There's >> nothing intrinsic about >> that. >> > > That is good news; the bug specifically affected NCQ'd TRIM commands. > Performing TRIM manually is an admin headache and gets old, fast. We don't do NCQ Trims today. When I deployed, I had massive corruption on M500's that I developed for after a few hours to days. We do have non-NCQ Trims and those work just fine on these drives. However, they serialize other reads and writes. I hope to forward port this to -current soon. Warner