From owner-svn-src-all@freebsd.org Fri Sep 11 17:00:39 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B19D33E0644; Fri, 11 Sep 2020 17:00:39 +0000 (UTC) (envelope-from gjb@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Bp27q4JYdz4ZnF; Fri, 11 Sep 2020 17:00:39 +0000 (UTC) (envelope-from gjb@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1599843639; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eLoQyO41kaKk3+NdXQ1MOCkYeTyfolhFPhHqmXg2nYo=; b=dZtxVBy4ZAXczKIXj/7DRwSX5JHlWUckG925yHIgCdBGmTUnSpHr3rqCZEfVNwo7hL5Wfh jsuaBcINC8lz3GPz5CH3yXv+LcecSjwj6ZhARexVtmBhRaXe2S+q1PjiEMNHjuCQIiq8XF A8Udfc0FpsaAZyTwCYmmjst3EhARI7QxeFVTHI3CPX4OkWnsCVgJAzYXU8f2D2j+Eb0ABo 4oSpm+1KbNsqVtG/1ibMtG3hOzLqp+S0FysM+AxFKl2fFTkKIoGAz+TcDP+0HG4oQigC0E aTGa/08+t83wH5CYQRgO/xCJdivnEMJl8BY6HNAsAo3+DDsCtJhchTQkAbCi1g== Received: from FreeBSD.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id 266C92115; Fri, 11 Sep 2020 17:00:39 +0000 (UTC) (envelope-from gjb@freebsd.org) Date: Fri, 11 Sep 2020 17:00:36 +0000 From: Glen Barber To: Ruslan Garipov Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r364891 - in head: . release release/scripts Message-ID: <20200911170036.GD61041@FreeBSD.org> References: <202008272119.07RLJGgb043888@repo.freebsd.org> <174719d0148.27b9.e2363f32305322128423a5fd7014e4c4@gmail.com> <20200909135114.GC61041@FreeBSD.org> <1747c711988.27b9.e2363f32305322128423a5fd7014e4c4@gmail.com> <20200911125525.GC61041@FreeBSD.org> <6d1dd875-c0d6-0006-d829-905534728589@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="JMkwMgK6e0iG7uLb" Content-Disposition: inline In-Reply-To: <6d1dd875-c0d6-0006-d829-905534728589@gmail.com> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1599843639; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eLoQyO41kaKk3+NdXQ1MOCkYeTyfolhFPhHqmXg2nYo=; b=wQrV/bkAGdePNM5c30ZQJDkA8sUYVYeo/othR+1JnD5MlY71a6cvu6QP+qQKzegcfwXEIs 38Ka7iF88SAFzI06rOLnNQKUy0/z7Fj/CweKDXal37+qY1RzmWgqkttRC216+oI6Qk+amC hckoED+ihWmD9rMrnFhcZBmBB7GagO0G9p6e5dPKcJ0BJMHaN7fH0ocL72u0w6ai+4I1UF JakIhjW9vBJ7K/6KUZNmt2/dbv/AoHdQfKy1ZUKytcBpmoWmyOs2EoCsUZQhNd2vAiw8hM TyEgy/CZ0C8475mkjR9MRKHjboCB03Eqqe3hiTOe049Fd60g0+6Hd3PapiHLwg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1599843639; a=rsa-sha256; cv=none; b=cvZ1FDTzrhLanm1VyV0staXY5emiAG0CDMmhejGRCdDJlESfSPQcffs7xrhVaBW7t2Nz4F DkUU0ZdaFMkIOlLyzKWYtWYUXNa89gMwxEMPxaGt06DngKsK2NEBxRBJSHrNeI1oxq3FUa 5hv3/nNmdagiZKw88xRdGY3cfJlfC6GocePFI8vjysTwy0fF5e16kanDZQ4HmZ4LnKTKJS 5sSDWWe3Hkoq3AVVgHj8W/ZMd0OwwQeWjTIvgfTC9rLtmsRcZR4kbu7yUa/Jy4Iv6/oh2a u+IOAmCXxqSiybQu2O4xd03qVQp0dF8bDvkIl3QlRC1KEiUIciEKCa1SzLnF+A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Sep 2020 17:00:39 -0000 --JMkwMgK6e0iG7uLb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 11, 2020 at 09:56:31PM +0500, Ruslan Garipov wrote: > On 9/11/2020 5:55 PM, Glen Barber wrote: > > So as far as you are concerned, with the addition of removing the '!', > > it works as you expect? > Yes, it does. >=20 > Should we also "fix" env_setup()? Which also checks NOGIT for zero > length. What if one set NOGIT up outside release.conf as NOGIT=3D1 (I > don't do that). Does he/she end up with "The devel/git is required"? Yes, you are correct. I made the same mistake twice... I will commit it shortly with both things fixed. Glen --JMkwMgK6e0iG7uLb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEjRJAPC5sqwhs9k2jAxRYpUeP4pMFAl9brTQACgkQAxRYpUeP 4pPz6g/8CaJZI/60eoQPBMbcDca5lPTIXUz7DC1LzC7XOvRz3wD7kthur49cvBUP oOq6Qg4ziFo45hRVus5Ckrocqrn6Oj6HP51W9+Yp8QKWjeK8IofMTduOY8KzzzkU AkdXQ7VZhig9b8Yr2v9PtHU1L09QpDKBkIgfXYU2Wn/8ZWhblN77b0fzWHwTPg25 m4kE19odRrgxp5WS4qfaIzNLbE04N5l0Iof87xefpX+M17BiGlk0CEV9z+ZzK9oL Ta3nsNRfXpHW1bt85x6XEIS+mDmomZGJkYQo2NlVJTnp1HbaDs+LFOt6SDpJ3erN J2I5KZQ/7xfO62au1hWsZ8DfpVXwKcWPbKwqENXC9WD5Rm+WNS+/wrHzl+A3viQu iKE9kXFoExqVsHNwlo4J1ckfDc1OqjPokB0Uc5PbO8KcDdyQrQHkkT/9+xlO1oxE 12CykEl2KzxaRPy6EFyh2mC/SJ+k2h58BmnzMpqN3WnxS1Bv/TTfoLr5fFzyOx8f VFRzyuFzhanFh7N1WUWpPLxr8wh9K7F3x7A4RB576ZYr3SR9cjH92SEzq9xGi5et DGnj/AowFC0/U7KQ5QbEqyhvKShkSj0wVdhPXJHH0zWjW3QDY22OCCPu1gLwFD7+ g1Em6Ga1dqTJLm26Tgu0Wdg0TU3zzI/f7C3hclEsvu7QDCUlBGE= =/NnJ -----END PGP SIGNATURE----- --JMkwMgK6e0iG7uLb--