From owner-svn-src-head@FreeBSD.ORG Mon Jun 30 22:36:16 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3F3CDB38 for ; Mon, 30 Jun 2014 22:36:16 +0000 (UTC) Received: from mail-qa0-x22c.google.com (mail-qa0-x22c.google.com [IPv6:2607:f8b0:400d:c00::22c]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CF17A2D84 for ; Mon, 30 Jun 2014 22:36:15 +0000 (UTC) Received: by mail-qa0-f44.google.com with SMTP id hw13so6995489qab.17 for ; Mon, 30 Jun 2014 15:36:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=cFGYo5NEpSlAVewXwcz/bVo+AM5rK4Yx+Lb9wyDcqHk=; b=hlT8yyqn0ji17oVryzbErgyclpNzA/l9qPOP5TX1EeVTiV96fVHvpgAl6KClcRZL+D GUeP0yyyLT3ip+A+Hi0ozErNsA/JF0UWRhqqiNzWas8oRZWvTmCEJqgSfIt9pPWbqXxJ ThG2j9gV5zaVt6O9NOp+/2mCT+5rrSIYbO1Y4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-type; bh=cFGYo5NEpSlAVewXwcz/bVo+AM5rK4Yx+Lb9wyDcqHk=; b=QWOh9KjSuuNZclYwvqoaCegqOR/UEIdMhf2ckGyT3NWQ5xQRsCRYD5nvFENf1TJQA/ imONfSTJ6MJZ9HsN6TbLe2tm7rzmC7GIgbyA/thnzuZPD6wSVaEe/HlZYKh6Zr4uNPB4 yEmcKm0NH4ILf3CzZFB/SkYB0/EkZlUMjM/6z9IP2KMD8BiYi3XYi2aPcqeYpZ3/TMOg 4AfR0xPT4g2inOaoP4vdXGmenNOFXX9nQeOKp8iRaEI74DlyUMP3TFGI+aORgt2C1wET ZyIxfJFbHpJ5kfFrFZglqD4WPH6pQaRDCP8KpaB8M358iRdFnRa1dhdY8vUM3BvZt2DS S4FQ== X-Gm-Message-State: ALoCoQmooamgWBFn4CVR60sX4ASMHYfh70MM9HhdgsUlfOXcpHEoEM0mGmOzmuKoGTs/02dBOOQU X-Received: by 10.224.171.195 with SMTP id i3mr66831924qaz.44.1404167774813; Mon, 30 Jun 2014 15:36:14 -0700 (PDT) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.96.88.132 with HTTP; Mon, 30 Jun 2014 15:35:44 -0700 (PDT) In-Reply-To: <201406301703.25593.jhb@freebsd.org> References: <201406301811.s5UIBMxh036571@svn.freebsd.org> <201406301447.21620.jhb@freebsd.org> <20140630201555.GE7615@alchemy.franken.de> <201406301703.25593.jhb@freebsd.org> From: Eitan Adler Date: Mon, 30 Jun 2014 15:35:44 -0700 X-Google-Sender-Auth: YlaPahxFGAcirUZN_186GFWmzCY Message-ID: Subject: Re: svn commit: r268055 - head/sys/sys To: John Baldwin Content-Type: text/plain; charset=UTF-8 Cc: Hans Petter Selasky , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Marius Strobl X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jun 2014 22:36:16 -0000 On 30 June 2014 14:03, John Baldwin wrote: > On Monday, June 30, 2014 4:15:55 pm Marius Strobl wrote: >> On Mon, Jun 30, 2014 at 02:47:21PM -0400, John Baldwin wrote: >> > On Monday, June 30, 2014 2:43:42 pm Hans Petter Selasky wrote: >> > > On 06/30/14 20:37, John Baldwin wrote: >> > > > Reindenting the whitespace made this diff harder to read. Why hasn't this >> > > > been a problem before on powerpc64? >> > > >> > > Hi, >> > > >> > > This has not been a problem before, because producers of DATA_SET()'s >> > > were using syntax along these lines: >> > > >> > > static int test2; >> > > static int test3; >> > > >> > > DATA_SET(test, test2); >> > > DATA_SET(test, test3); >> > > >> > > Now if you change this simple code to: >> > > >> > > static int test2; >> > > int test3; >> > > >> > > DATA_SET(test, test2); >> > > DATA_SET(test, test3); >> > > >> > > It breaks on powerpc64. Should be very easy to reproduce. >> > > >> > > The problem with SYSCTL's is that some are global and some are not. >> > > Before an indirect pointer was hiding this problem from appearing. >> > > >> > > Do you see? Or do you want me to explain more. >> > >> > Ahh, ok. Seems odd that this sort of thing would be ppc64-specific however. >> > >> >> Apparently it isn't and has also has shown up on at least ia64: >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=31490 > > Ugh. Maybe this should be conditional on the GCC version rather than ppc64? There should also be a GCC bug id in a comment. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams