Date: Thu, 04 Jun 2015 16:12:17 +0200 From: Jan Beich <jbeich@vfemail.net> To: Tijl Coosemans <tijl@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r388498 - head/multimedia/dvdstyler Message-ID: <twun-ef5q-wny@vfemail.net> In-Reply-To: <201506040756.t547uJN4005594@svn.freebsd.org> (Tijl Coosemans's message of "Thu, 4 Jun 2015 07:56:19 %2B0000 (UTC)") References: <201506040756.t547uJN4005594@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-=-=
Content-Type: text/plain
Tijl Coosemans <tijl@FreeBSD.org> writes:
> - Replace CXXFLAGS+=-std=c++11 with USE_CXXSTD.
[...]
> +USE_CXXSTD= gnu++11
[...]
> -.if ${CHOSEN_COMPILER_TYPE} == "gcc"
> -CXXFLAGS+= -std=c++11
> -.endif
Why "gnu" dialect of c++11 ? If clang/libc++ fail to build the port
otherwise you should say so in the commit message. At least r383466
itself doesn't require "gnu".
$ fgrep -i std x11-toolkits/wxgtk30/Makefile
CXXFLAGS+= -std=c++11
--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQF8BAEBCgBmBQJVcFzBXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQjQ0MzY3NEM3RDIzNTc4NkUxNDkyQ0VF
NEM3Nzg4MzQ3OURCRERCAAoJEOTHeINHnb3b/3MH/RNYQiNfwByQcu2GY5dCF9br
GChiy4EqTyMvH3Dt06tyzdbmuAsGtRk6A4uyq4IP7rIjXS7HIYeFrB1MJPc9UX1B
UaTiIyKgmxUHZVT2gxVjKebMz3PJkz3m4XWCgEVwe7pF3aRRE8wcNznBvqnhAEWb
MIJXRuAqu5xBMAF888YCU8rTiCtGbqckhzwbw7D9JfRKakLdKBAwM55Nw2PYDizV
Nw0Q0M9eGuUNiALnq1nJJAY5/o6a8mNI8mZ4IRXW+eYj79XKrhrfjOx9/Q/SpuzK
xW7860GZ1Ob1TzjhN1fP6VP+gzvukpk7eSf9WVDJNnUtY6HJ9fnEE6iKnPfg1vI=
=CYyQ
-----END PGP SIGNATURE-----
--=-=-=--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?twun-ef5q-wny>