From owner-cvs-all Sun May 12 18:26:27 2002 Delivered-To: cvs-all@freebsd.org Received: from kayak.xcllnt.net (209-128-86-226.bayarea.net [209.128.86.226]) by hub.freebsd.org (Postfix) with ESMTP id 06D2737B404; Sun, 12 May 2002 18:26:21 -0700 (PDT) Received: from athlon.pn.xcllnt.net (athlon.pn.xcllnt.net [192.168.4.3]) by kayak.xcllnt.net (8.11.6/8.11.4) with ESMTP id g4D1QKJ99458; Sun, 12 May 2002 18:26:20 -0700 (PDT) (envelope-from marcel@kayak.pn.xcllnt.net) Received: from athlon.pn.xcllnt.net (localhost [127.0.0.1]) by athlon.pn.xcllnt.net (8.12.3/8.12.3) with ESMTP id g4D1QKuJ002066; Sun, 12 May 2002 18:26:20 -0700 (PDT) (envelope-from marcel@athlon.pn.xcllnt.net) Received: (from marcel@localhost) by athlon.pn.xcllnt.net (8.12.3/8.12.3/Submit) id g4D1QJ83002065; Sun, 12 May 2002 18:26:19 -0700 (PDT) (envelope-from marcel) Date: Sun, 12 May 2002 18:26:19 -0700 From: Marcel Moolenaar To: "Greg 'groggy' Lehey" Cc: Garrett Wollman , Luigi Rizzo , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet ip_fw.c Message-ID: <20020513012619.GA1967@athlon.pn.xcllnt.net> References: <200205122043.g4CKhod56192@freefall.freebsd.org> <20020512230017.GB4770@genius.tao.org.uk> <20020512163100.A26082@iguana.icir.org> <200205122343.g4CNhP7X023643@khavrinen.lcs.mit.edu> <20020513092718.A13919@wantadilla.lemis.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020513092718.A13919@wantadilla.lemis.com> User-Agent: Mutt/1.3.27i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, May 13, 2002 at 09:27:18AM +0930, Greg 'groggy' Lehey wrote: > On Sunday, 12 May 2002 at 19:43:25 -0400, Garrett Wollman wrote: > > < said: > >> I know, > >> but > >> sometimes > >> it is > >> unavoidable > >> to move > >> to 4 > >> spaces. > > > > If the code is > > lined up down > > the right hand > > side of the > > screen, then > > it almost > > certainly > > needs to be > > refactored -- > > not > > reindented! > > If the code is lined up down the right hand side of the screen, > then maybe it's the screen which needs to be remade, not the > code. Why should we still live in the shadow of punched cards? The argument that code looks better or is more readable when indented with 4 spaces as compared to 8 spaces can be applied recursively and transitively to yield that code looks better or is more readable when not indented at all. Since this is obviously a silly statement, I can only conclude that the whole reasoning is flawed. The eternally recurring style(9) debate is the other dead givaway that it's not solving anything, but rather creates problems. So, please stop it already. We're going to end right here where we started and the only thing we gained is frustration. Compared to what we can loose, developers, I'd say it's not worth it... Thanks, \begin{brainfart} CRA n. Compulsive Reintenders Anonymous. A support group for people with an unnatural tendency to reindent anything not indented with their favorite spacing. \end{brainfart} ;-) (sorry, couldn't resist and I'm probably going to be very sorry I put it here) -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message