From owner-freebsd-commit Thu Oct 12 06:42:18 1995 Return-Path: owner-commit Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id GAA12239 for freebsd-commit-outgoing; Thu, 12 Oct 1995 06:42:18 -0700 Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id GAA12149 for cvs-all-outgoing; Thu, 12 Oct 1995 06:40:55 -0700 Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id GAA12133 for cvs-sys-outgoing; Thu, 12 Oct 1995 06:40:52 -0700 Received: from Root.COM (implode.Root.COM [198.145.90.17]) by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id GAA12120 ; Thu, 12 Oct 1995 06:40:43 -0700 Received: from corbin.Root.COM (corbin [198.145.90.50]) by Root.COM (8.6.12/8.6.5) with ESMTP id GAA21894; Thu, 12 Oct 1995 06:40:42 -0700 Received: from localhost (localhost [127.0.0.1]) by corbin.Root.COM (8.6.12/8.6.5) with SMTP id GAA00191; Thu, 12 Oct 1995 06:40:41 -0700 Message-Id: <199510121340.GAA00191@corbin.Root.COM> To: Peter Dufault cc: julian@freefall.freebsd.org (Julian Elischer), CVS-commiters@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/scsi sd.c st.c In-reply-to: Your message of "Thu, 12 Oct 95 05:35:27 EDT." <199510120935.FAA02039@hda.com> From: David Greenman Reply-To: davidg@Root.COM Date: Thu, 12 Oct 1995 06:40:41 -0700 Sender: owner-commit@FreeBSD.org Precedence: bulk >> >> julian 95/10/11 19:02:06 >> >> Modified: sys/scsi sd.c st.c >> Log: >> Ack! >> sometime around 1.51, the check for minphys dissappeared out of >> transfers for disks.. >> we weren't hecking that the adapter could handle a transfer of >> the size we were requesting.. >> Peter!? >> :) > >I moved it up into scsi_strategy. I apparently missed the raw I/O >case. > >> this explains the rash of failures I've seen reported recently >> with "too many DMA segments" on raw devices >> >> (added one for st as well) > >Can you put it in scsi_read/scsi_write instead so that all devices >will have it? Certainly the worm (if anyone ever gets one to test) >will need it. How important is this fix? We've pretty much frozen the 2.1-stable code, so I'm very reluctant to make any further changes unless they are show-stoppers. -DG