From owner-freebsd-current@FreeBSD.ORG Thu Nov 21 12:11:50 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 2A283183; Thu, 21 Nov 2013 12:11:50 +0000 (UTC) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id DCFC922B6; Thu, 21 Nov 2013 12:11:49 +0000 (UTC) Received: from [192.168.2.2] (unknown [77.243.161.229]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id C6FB95C43; Thu, 21 Nov 2013 13:11:45 +0100 (CET) Content-Type: multipart/signed; boundary="Apple-Mail=_4225750B-D051-4013-BCB4-986C82579E93"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 7.0 \(1822\)) Subject: Re: Duplicated WITH_*/WITHOUT_* options From: Dimitry Andric In-Reply-To: Date: Thu, 21 Nov 2013 13:11:30 +0100 Message-Id: <9A9B2AFC-A96D-4B63-9ABD-40E4BAA8FD3E@FreeBSD.org> References: <20131119162205.GW1643@glenbarber.us> <20131119231325.GA1527@glenbarber.us> <35.00.29861.FA61C825@cdptpa-oedge02> To: Mark Robert Vaughan Murray X-Mailer: Apple Mail (2.1822) Cc: FreeBSD CURRENT X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Nov 2013 12:11:50 -0000 --Apple-Mail=_4225750B-D051-4013-BCB4-986C82579E93 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On 21 Nov 2013, at 09:44, Mark Robert Vaughan Murray = wrote: > I noticed we have some duplicated WITH_*/WITHOUT_* options; presumably = this is an oversight? >=20 > [graveyard] /usr/src/tools/build/options 08:37 am # for i in WITH_* ; = do if [ -e WITHOUT_${i##WITH_} ] ; then echo WITHOUT_${i##WITH_} ${i} ; = fi; done >=20 > WITHOUT_CLANG WITH_CLANG > WITHOUT_CLANG_FULL WITH_CLANG_FULL > WITHOUT_CLANG_IS_CC WITH_CLANG_IS_CC > WITHOUT_FDT WITH_FDT > WITHOUT_GCC WITH_GCC > WITHOUT_GNUCXX WITH_GNUCXX > WITHOUT_LIBCPLUSPLUS WITH_LIBCPLUSPLUS > WITHOUT_NAND WITH_NAND > WITHOUT_TESTS WITH_TESTS >=20 > As its not all that obvious which one =93wins=94, can this be cleaned = up? I don=92t mind doing the work if there is a somewhat foolproof way = of doing so. These duplicated settings are not oversights, just artifacts of how bsd.own.mk works. The defaults are simply different for different arches, e.g. WITH_CLANG is the default for x86, powerpc and LE arm, but WITHOUT_CLANG is the default for other arches. Similar for the other settings. -Dimitry --Apple-Mail=_4225750B-D051-4013-BCB4-986C82579E93 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) iEYEARECAAYFAlKN+HsACgkQsF6jCi4glqPLygCeNC4vP5FEt7hMCQm3pMzWy2Wr UOYAnRPVW/hJerf03CsJbY9ob7C0noaQ =pTrf -----END PGP SIGNATURE----- --Apple-Mail=_4225750B-D051-4013-BCB4-986C82579E93--