From nobody Sun Nov 26 04:11:05 2023 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SdFdP54y2z52lP1 for ; Sun, 26 Nov 2023 04:11:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SdFdP2kVjz3LLN for ; Sun, 26 Nov 2023 04:11:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1700971865; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QdlO0oS5DLjdD2LmoABLr3Cdlx3yqdHZsR89IxQ+1O8=; b=P1PWHDXcPo5w6uixsAhFY03pTD8wyYQRkJzObDcH+to0Mm5eX7d0FGvlo6mWUZ7NtBQGhy 0FlYVCYZLe3ITLOXE1g+cvFjTQd2R8Rc3MHgSJ5f9X7nEQ5hzsllpm90MU2UiCZa2Fciod wLlmQGsCdtf4VaJsT51bn/gm/B7Sam7DseipcOJiRQDLVFLnpsInz/wL52pM8WfrYkkypc JR3F8bM52yi4yqWc+3KVxaWUmk4m89IzSRTYzFy4Fbdq/jXuv1mqQlJ1SgaAIZ44njAikG ahoi3zUbOgKD5kpBDGtgTR7a0J/OvE7BqiVydJXvaqJy8zXwFJeGvHUFdBu1cw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1700971865; a=rsa-sha256; cv=none; b=iJHJTu8zZhaMGlAm9mvQ/cElP8rCY4s4yD/0lXRkSMR3fvQdeqnDv7UfWSqUucs8A6YqJ0 DpIzQ34ET7c8eHLPERDLd82YyBbaD9zUwJzLvqYFJm+SAAtlcB7YXqMsKnWHltjli56c4V Rha4zmsW2dJxSMniLRqtvZ+mQr68vn3hXE8QuWhk0AkrBSwdzbc0lzb5MOcCYE5NS5dpxl z39Rc0AyhqjwzD7hV66eM13GssBdLeBWCDt9d39jBAqxiiU5q5UvuCEwq7Pn9L+q8VMXMo 153Z4qK3rFjNj4GGNS+bwbh1spbb6WKTZs7Y0cCwarlfPuDUhnkVMyPsATQICQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SdFdP1J1wzgsy for ; Sun, 26 Nov 2023 04:11:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 3AQ4B50l011682 for ; Sun, 26 Nov 2023 04:11:05 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 3AQ4B5Va011681 for bugs@FreeBSD.org; Sun, 26 Nov 2023 04:11:05 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 112379] [patch] [request] lockf(1): on closing stdin, stdout, stderr Date: Sun, 26 Nov 2023 04:11:05 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: Unspecified X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: kevans@freebsd.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D112379 --- Comment #4 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D18425c19cae08cbe41801845457ed6728= 5806688 commit 18425c19cae08cbe41801845457ed67285806688 Author: Alexander Melkov AuthorDate: 2023-11-22 04:46:28 +0000 Commit: Kyle Evans CommitDate: 2023-11-26 04:09:27 +0000 lockf: don't hold stdin/stdout/stderr open None of these are essential in the lockf monitor (parent post-fork), so close them to maintain the illusion that lockf hasn't been inserted into the pipeline. This ensures that the correct effects happen on other programs in the pipeline if the locked command closes or redirects these elsewhere. The original patch used -s to close stdout/stderr rather than closing them unconditionally, but it's not clear that we really care that much. kevans dropped that part when taking the patch, patch is otherwise by listed author. PR: 112379 Reviewed by: 0mp, allanjude (both earlier version), kevans Feedback from: des Sponsored by: Klara, Inc. Differential Revision: https://reviews.freebsd.org/D42713 usr.bin/lockf/lockf.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) --=20 You are receiving this mail because: You are on the CC list for the bug.=