From owner-svn-src-head@FreeBSD.ORG Mon Jun 30 23:34:47 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 982F88EC; Mon, 30 Jun 2014 23:34:47 +0000 (UTC) Received: from mail-qg0-x22e.google.com (mail-qg0-x22e.google.com [IPv6:2607:f8b0:400d:c04::22e]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 34E3E225B; Mon, 30 Jun 2014 23:34:47 +0000 (UTC) Received: by mail-qg0-f46.google.com with SMTP id q107so2614802qgd.19 for ; Mon, 30 Jun 2014 16:34:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=zlqw00DHL23FGG7vI2fbJBDHh/uQXN6FuIWTDGkLi8w=; b=dGvq4NID5YWmXlFZwHH2Tq1Dxg81AU1toiEgMDc6yBboIf2zVacw+kqRDHrMxOKwX2 dPj3y0oisoQWqQwQV+5WOAUWhpRPK4I8nzYAs/503vmyAcStz3JxLoxIWNqoIkXmyns1 8lvH86YhcdDHgQshkkf1s9eKhdxTj3hot1E05JOfq0QcoXbDr+PLZVLPtQSk49PdMkid S06rEHTneBBja3MtdxHZIO4v0ZP0/BkDeuVCUDQbiUjdZzIpGROXWNrluK+vYSrXeb2w 06Qo8FpvrWwgq44RNgMJgQ7rN0ailu6e2x8sV7+g4a0daTL+KBIhCYTcsVGLuQ9gvOA6 9Cfw== MIME-Version: 1.0 X-Received: by 10.224.130.136 with SMTP id t8mr1865118qas.49.1404171286080; Mon, 30 Jun 2014 16:34:46 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.224.202.193 with HTTP; Mon, 30 Jun 2014 16:34:46 -0700 (PDT) In-Reply-To: <20140630150658.GA4742@onelab2.iet.unipi.it> References: <201406300434.s5U4YxGY043870@svn.freebsd.org> <20140630150658.GA4742@onelab2.iet.unipi.it> Date: Mon, 30 Jun 2014 16:34:46 -0700 X-Google-Sender-Auth: iJGKCDgjZyadwIbKFDLrnW_4yGw Message-ID: Subject: Re: svn commit: r268028 - head/sys/dev/e1000 From: Adrian Chadd To: Luigi Rizzo Content-Type: text/plain; charset=UTF-8 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jun 2014 23:34:47 -0000 Fixed in both! thanks! -a On 30 June 2014 08:06, Luigi Rizzo wrote: > On Mon, Jun 30, 2014 at 04:56:01PM +0200, Luigi Rizzo wrote: >> I am getting the following error while compiling with gcc: >> >> cc1: warnings being treated as errors >> /usr/home/luigi/FreeBSD/head/sys/dev/e1000/if_igb.c: In function >> 'igb_attach': >> /usr/home/luigi/FreeBSD/head/sys/dev/e1000/if_igb.c:2461: warning: 'cpu_id' >> may be used uninitialized in this function >> /usr/home/luigi/FreeBSD/head/sys/dev/e1000/if_igb.c:2461: note: 'cpu_id' >> was declared here >> >> (the code is correct, apparently gcc cannot understand that). >> >> For compatibility i'd throw in an explicit initialization, >> however it might be worthwhile rewriting the code with a single >> if (adapter->num_queues > 1) { ...} block within the for(), >> and also using only one #ifdef RSS -- the other places only >> differ in the string passed to diagnostics or comments. > > and the same goes for the recent changes to ixgbe.c > > cheers > luigi