From owner-freebsd-current@FreeBSD.ORG  Tue Mar 18 19:29:36 2014
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id D3F8C3D3;
 Tue, 18 Mar 2014 19:29:36 +0000 (UTC)
Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1])
 (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id AC8F918D;
 Tue, 18 Mar 2014 19:29:36 +0000 (UTC)
Received: from jhbbsd.localnet (unknown [209.249.190.124])
 by bigwig.baldwin.cx (Postfix) with ESMTPSA id 7E911B941;
 Tue, 18 Mar 2014 15:29:32 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: freebsd-current@freebsd.org
Subject: Re: vm_map.h
Date: Tue, 18 Mar 2014 14:23:55 -0400
User-Agent: KMail/1.13.5 (FreeBSD/8.4-CBSD-20130906; KDE/4.5.5; amd64; ; )
References: <BLU179-W51BFCABBB6A0019AB97DF9C6760@phx.gbl>
 <201403131400.59282.jhb@freebsd.org>
 <BLU179-W590AB6C3D34C4FED71746C6710@phx.gbl>
In-Reply-To: <BLU179-W590AB6C3D34C4FED71746C6710@phx.gbl>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Message-Id: <201403181423.55276.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
 (bigwig.baldwin.cx); Tue, 18 Mar 2014 15:29:32 -0400 (EDT)
Cc: Bruno =?iso-8859-1?q?Lauz=E9?= <brunolauze@msn.com>,
 Alan Cox <alc@freebsd.org>
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Mar 2014 19:29:36 -0000

On Thursday, March 13, 2014 6:46:13 pm Bruno Lauz=E9 wrote:
> I suggesting this because it is used more ahead in the same file, but the=
 other way around is fine for me

No need to move them around:

Index: vm_map.h
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
=2D-- vm_map.h	(revision 263302)
+++ vm_map.h	(working copy)
@@ -188,8 +188,10 @@ struct vm_map {
 	vm_flags_t flags;		/* flags for this vm_map */
 	vm_map_entry_t root;		/* Root of a binary search tree */
 	pmap_t pmap;			/* (c) Physical map */
+#ifdef _KERNEL
 #define	min_offset	header.start	/* (c) */
 #define	max_offset	header.end	/* (c) */
+#endif
 	int busy;
 };
=20
> ----------------------------------------
> > From: jhb@freebsd.org
> > To: freebsd-current@freebsd.org
> > Subject: Re: vm_map.h
> > Date: Thu, 13 Mar 2014 14:00:59 -0400
> > CC: brunolauze@msn.com; alc@freebsd.org
> >
> > On Wednesday, March 12, 2014 5:13:28 pm Bruno Lauz=E9 wrote:
> >> The two defines in vm/vm_map.h
> >>
> >> #define min_offset header.start /* (c) */
> >> #define max_offset header.end /* (c) */
> >>
> >>
> >> are really getting in the way because those words are most likely to b=
e used
> > downstream.
> >>
> >> I would suggest renaming those defines to:
> >>
> >> #define vm_min_offset header.start /* (c) */
> >> #define vm_max_offset header.end /* (c) */
> >>
> >> Am I missing something?
> >
> > A simpler fix is probably to put the #define's under #ifdef _KERNEL.
> >
> > --
> > John Baldwin

=2D-=20
John Baldwin