From owner-svn-src-all@freebsd.org Sat Jul 7 17:43:58 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9340F103B0A3; Sat, 7 Jul 2018 17:43:58 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-wm0-x22a.google.com (mail-wm0-x22a.google.com [IPv6:2a00:1450:400c:c09::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 08ED682A67; Sat, 7 Jul 2018 17:43:58 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-wm0-x22a.google.com with SMTP id v16-v6so17478178wmv.5; Sat, 07 Jul 2018 10:43:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ZlkA9S5DTWO5zDACQaGPy4HtWY3dwi9qAyPTDP9ZIkg=; b=a1dfbj5s48YSbmANwTLh5RbwgF9Sa3mKkp1Dd1x31pQ/oVZ7D82aNbT+GeBNGxSr77 G3mFVgJSYFcknnS/Ted/gCTB+Apufh7JBKp93KFnauk1E9Vz4nTtfZIkgmKG946Mb/vp kPuwUp0lWXRBsvDg9i0p7Nil2t6l0CTuVtm8g3Uu6xHb4F1Aa/7g76xlXo8m2Zq/TEiN 0nprAXkxTHtlKoRAyJqDgutBm3aZlP3OeHNpWogOSJFfZPJ7omxj9ILr1HhjE/aYjDej J2fCAvj/iGxKCXPrhTqvqaj2M5bW3RA3Wjxq+RRuD5nILNDPykw7nt/yKbI0xThFbsya xHqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=ZlkA9S5DTWO5zDACQaGPy4HtWY3dwi9qAyPTDP9ZIkg=; b=RV/mcvQP6Cki17Lfv1of7ivMFBFP+kJ0TEs31dzr7WyniC5d755UhKWRqrPsa2rpT6 AE4zArcbYcu7KOIe8VTz6mL70oVb2TjDCsoEE1CP6WLZXHTCKHxCpC3Nlfh5f/iqxxV/ YXbYxsC6g+RRzv5WtOKnsyceMjWQvJmj7oSTvUFE3qeZcqaXxsEZlcno6+HW3MtoCG1b E70IA0hiIh+8voQYPi6eHWziC7ZBIOInwaF59UZTILSx9GzvdE+niDe7F2xzgOs5nQKk 3noiJEsDfEgprDJAoi5O1pB85TnCQpRg24QYXyNyJrGcEeiKK5i8uqmwW6Qh1nP1ExvD emqA== X-Gm-Message-State: APt69E13hSwSjxuZW/SRDPEAhIAZkRUK6vaIlVkhuv/wsvnXJIcT9aYz ysIm+DLQUMGbqem934rj4HtzhQ== X-Google-Smtp-Source: AAOMgpe+lQtbbYg9Q/3VMbiC2pctrw0lb01hKWrrRhdgDLNCX5oL+NHEH4TjjDu9PUhnL9YznlFGOA== X-Received: by 2002:a1c:3693:: with SMTP id y19-v6mr8214036wmh.71.1530985436839; Sat, 07 Jul 2018 10:43:56 -0700 (PDT) Received: from pesky (174.red-81-43-74.staticip.rima-tde.net. [81.43.74.174]) by smtp.gmail.com with ESMTPSA id d14-v6sm4427332wma.13.2018.07.07.10.43.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 07 Jul 2018 10:43:55 -0700 (PDT) Sender: Mark Johnston Date: Sat, 7 Jul 2018 13:43:51 -0400 From: Mark Johnston To: Andrew Turner Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, sbruno@freebsd.org Subject: Re: svn commit: r334880 - head/sys/dev/vnic Message-ID: <20180707174351.GA95934@pesky> References: <201806091447.w59ElnpU026396@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201806091447.w59ElnpU026396@repo.freebsd.org> User-Agent: Mutt/1.10.0 (2018-05-17) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Jul 2018 17:43:58 -0000 On Sat, Jun 09, 2018 at 02:47:49PM +0000, Andrew Turner wrote: > Author: andrew > Date: Sat Jun 9 14:47:49 2018 > New Revision: 334880 > URL: https://svnweb.freebsd.org/changeset/base/334880 > > Log: > In the ThunderX BGX network driver we were skipping the NULL terminator > when parsing the phy type, however this is included in the length returned > by OF_getprop. To fix this stop ignoring the terminator. > > PR: 228828 > Reported by: sbruno > Sponsored by: DARPA, AFRL This seems to break vnic on packet.net ThunderXs. In particular, VF creation fails. It seems the problem in my case is that there are multiple PHY devices in the device tree, e.g., xfi@0, xfi@1. With this change, bgx_fdt_phy_name_match() fails to match against any device containing a unit address in the node name.