From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Sep 14 05:20:03 2009 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B0AE1106566C for ; Mon, 14 Sep 2009 05:20:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 8B47E8FC22 for ; Mon, 14 Sep 2009 05:20:03 +0000 (UTC) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n8E5K3UE088251 for ; Mon, 14 Sep 2009 05:20:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n8E5K3fF088250; Mon, 14 Sep 2009 05:20:03 GMT (envelope-from gnats) Resent-Date: Mon, 14 Sep 2009 05:20:03 GMT Resent-Message-Id: <200909140520.n8E5K3fF088250@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "Herbert J. Skuhra" Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4CCB71065670 for ; Mon, 14 Sep 2009 05:11:07 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 3A2E38FC0C for ; Mon, 14 Sep 2009 05:11:07 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n8E5B60K096516 for ; Mon, 14 Sep 2009 05:11:06 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id n8E5B65B096515; Mon, 14 Sep 2009 05:11:06 GMT (envelope-from nobody) Message-Id: <200909140511.n8E5B65B096515@www.freebsd.org> Date: Mon, 14 Sep 2009 05:11:06 GMT From: "Herbert J. Skuhra" To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/138801: [Patch] security/amavisd-new: make install overwrites amavisd.conf X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Sep 2009 05:20:03 -0000 >Number: 138801 >Category: ports >Synopsis: [Patch] security/amavisd-new: make install overwrites amavisd.conf >Confidential: no >Severity: serious >Priority: high >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Sep 14 05:20:03 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Herbert J. Skuhra >Release: FreeBSD 7.2-RELEASE-p2 >Organization: >Environment: FreeBSD amavis 7.2-RELEASE-p2 FreeBSD 7.2-RELEASE-p2 #0: Wed Jun 24 00:57:44 UTC 2009 root@i386-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC i386 >Description: ports/136151 removes ".include " and ".include " So when you upgrade the port your amavisd.conf is overwriten. install -o root -g vscan -m 640 /usr/ports/security/amavisd-new/work/amavisd-new-2.6.4/amavisd.conf /usr/local/etc >How-To-Repeat: # cp /usr/local/etc/amavisd.conf /usr/local/etc/amavisd.conf.bak # cd /usr/ports/security/amavisd-new/ # make deinstall ===> Deinstalling for security/amavisd-new ===> Deinstalling amavisd-new-2.6.4_2,1 You should manually remove the "vscan" group. You should manually remove the "vscan" user. You should manually remove the "/var/amavis" directory. You should manually remove the "/var/virusmails" directory. # ls -la /usr/local/etc/amavisd.conf -rw-r----- 1 root vscan 10649 13 sep 23:11 /usr/local/etc/amavisd.conf # make install clean # ls -la /usr/local/etc/amavisd.conf -rw-r----- 1 root vscan 34880 14 sep 07:03 /usr/local/etc/amavisd.conf >Fix: Re-add ".include " and ".include " Patch attached with submission follows: +++ Makefile 2009-09-13 22:57:20.000000000 +0200 @@ -222,6 +222,8 @@ RUN_DEPENDS+= ${LOCALBASE}/bin/tnef:${PORTSDIR}/converters/tnef .endif +.include "bsd.port.pre.mk" + pre-fetch: @${ECHO} "" @${ECHO} " **** UPGRADE WARNING: SQL SCHEMA CHANGED ****" @@ -305,4 +307,4 @@ ${LN} -s ${PREFIX}/sbin/amavisd-release ${PREFIX}/sbin/amavisd-requeue @${CAT} ${PKGMESSAGE} -.include +.include "bsd.port.post.mk" >Release-Note: >Audit-Trail: >Unformatted: