From nobody Fri Sep 26 09:56:29 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cY5Zj2Gtyz683Ty; Fri, 26 Sep 2025 09:56:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cY5Zj1Sdbz3G5Z; Fri, 26 Sep 2025 09:56:29 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758880589; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Ecl6ML0AVk79R0t62B1i1HytpUEn3sGQ2ubBzs4h14M=; b=wIQ+A+c4e5pj3w81fwooVontsClB1yHzqDh83v0t9/mwhZD2qdMmzQWDnnGbNFNqcLyiCz 8kgnWn3NZkIPuB72/dg/1GrJxHpDrJDddWScXEvCIRBZXrdkiDY/BoCgKx8VJftLHuj16d EmIfs6PoSutIoEhRqb1UWVhxxzo36CMSEyKxwV3o9VZrERY08q599eoE/kXz9jWGXQizTl UTyiYt30Sbw0wVpaVIRGzw06RDcTRlHxI/ZgC8WuDUzue1vadjdHD/+OXsx+zALUi86fhJ c5IQIyK0CHRFVQztxIURES6112qxrI8iJuao4HCzftgwTJxEBzgr+Ww2tZqLTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758880589; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Ecl6ML0AVk79R0t62B1i1HytpUEn3sGQ2ubBzs4h14M=; b=faq0Zm9ER6ml/XW7xlGjP+tWnqN08adQ6DCe2+BrdC6/xgCBh0ssRTuxvW52q1ikTSHWRf fnX9jO/sJaHaFnj9kLmKISio/34Z1wfWFCD3R6Aje+LUVtVPOViQ8A3x3Cy9iAbyTX8qrS w7p1MFmwFCLimeUJhDnmzsDQyWX0uVrgwqE2jTKvB6BMkAgciWINjwE9g1TcrG1+kuAr36 sVIcx8Ic+kPGO5iFKbl5Ye3gDvu6aXCZ8V21Rbps+5HvC9I0FFGjp1YyJr5fQhExB52o+7 zKG92tazSBJDov+mqtt+IlmtwQHuBeuNTDHJ+UEXGnYDLutros8VvCQE1c6Sqg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1758880589; a=rsa-sha256; cv=none; b=A9iX6nlqHPYWsk3xQHmwZ4rr6CZDYgHi7DS+WBym+9UfBUNmeV/kHrfuSqWwBZa1XUAHhu MxmbwA0LSu8EuhzYkhy5K2gdFbv++YFUF4wxvKyaAN50Qlq9xKUoTSAwzm20W9/ZopOeyx GCtq3dWA4AsDPtiDnjsLwW/uQ5hF6pAiBeYF+i5sUTlFdfqRBf4S/CAx4T7+NcPHvic8aj jD0D6tc/izoBzrxfi1OEBk42jADVIkSUhW8FIH+89a19Y4V0KiJkhVqbZo+StHnYklxoVC tvmokbj1E8U1YLwcqT9MFQhfpAyC0V3ULPp37+s03yWHc7SKAn09l3gzDZ96/w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cY5Zj0p00zk28; Fri, 26 Sep 2025 09:56:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 58Q9uTNI080584; Fri, 26 Sep 2025 09:56:29 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 58Q9uTgj080581; Fri, 26 Sep 2025 09:56:29 GMT (envelope-from git) Date: Fri, 26 Sep 2025 09:56:29 GMT Message-Id: <202509260956.58Q9uTgj080581@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Michael Tuexen Subject: git: ccbc5f307a66 - stable/15 - tcp lro: remove redundant check List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: ccbc5f307a664c0ffba6eb0665106164665dffe2 Auto-Submitted: auto-generated The branch stable/15 has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=ccbc5f307a664c0ffba6eb0665106164665dffe2 commit ccbc5f307a664c0ffba6eb0665106164665dffe2 Author: Michael Tuexen AuthorDate: 2025-09-23 18:28:54 +0000 Commit: Michael Tuexen CommitDate: 2025-09-26 09:56:15 +0000 tcp lro: remove redundant check Remove a check which is also done in tcp_lro_rx_common(). Reviewed by: gallatin Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D52683 (cherry picked from commit 43bbecaeb95fe5ea1d7acffab4f2874247ba6915) --- sys/netinet/tcp_lro.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/sys/netinet/tcp_lro.c b/sys/netinet/tcp_lro.c index 7512679bd4e9..64efa4bf060f 100644 --- a/sys/netinet/tcp_lro.c +++ b/sys/netinet/tcp_lro.c @@ -1428,17 +1428,6 @@ tcp_lro_rx(struct lro_ctrl *lc, struct mbuf *m, uint32_t csum) { int error; - if (((m->m_pkthdr.csum_flags & (CSUM_DATA_VALID | CSUM_PSEUDO_HDR)) != - ((CSUM_DATA_VALID | CSUM_PSEUDO_HDR))) || - (m->m_pkthdr.csum_data != 0xffff)) { - /* - * The checksum either did not have hardware offload - * or it was a bad checksum. We can't LRO such - * a packet. - */ - counter_u64_add(tcp_bad_csums, 1); - return (TCP_LRO_CANNOT); - } /* get current time */ binuptime(&lc->lro_last_queue_time); CURVNET_SET(lc->ifp->if_vnet);