From owner-svn-src-head@FreeBSD.ORG Tue Jul 1 04:23:23 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6655013C; Tue, 1 Jul 2014 04:23:23 +0000 (UTC) Received: from mail.turbocat.net (heidi.turbocat.net [88.198.202.214]) (using TLSv1.1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 656912904; Tue, 1 Jul 2014 04:23:22 +0000 (UTC) Received: from laptop015.home.selasky.org (cm-176.74.213.204.customer.telag.net [176.74.213.204]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 9A9B71FE02D; Tue, 1 Jul 2014 06:23:07 +0200 (CEST) Message-ID: <53B237BC.4090207@selasky.org> Date: Tue, 01 Jul 2014 06:23:24 +0200 From: Hans Petter Selasky User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Eitan Adler , John Baldwin Subject: Re: svn commit: r268055 - head/sys/sys References: <201406301811.s5UIBMxh036571@svn.freebsd.org> <201406301447.21620.jhb@freebsd.org> <20140630201555.GE7615@alchemy.franken.de> <201406301703.25593.jhb@freebsd.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Marius Strobl X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Jul 2014 04:23:23 -0000 On 07/01/14 00:35, Eitan Adler wrote: > On 30 June 2014 14:03, John Baldwin wrote: >> On Monday, June 30, 2014 4:15:55 pm Marius Strobl wrote: >>> On Mon, Jun 30, 2014 at 02:47:21PM -0400, John Baldwin wrote: >>>> On Monday, June 30, 2014 2:43:42 pm Hans Petter Selasky wrote: >>>>> On 06/30/14 20:37, John Baldwin wrote: >>>>>> Reindenting the whitespace made this diff harder to read. Why hasn't this >>>>>> been a problem before on powerpc64? >>>>> >>>>> Hi, >>>>> >>>>> This has not been a problem before, because producers of DATA_SET()'s >>>>> were using syntax along these lines: >>>>> >>>>> static int test2; >>>>> static int test3; >>>>> >>>>> DATA_SET(test, test2); >>>>> DATA_SET(test, test3); >>>>> >>>>> Now if you change this simple code to: >>>>> >>>>> static int test2; >>>>> int test3; >>>>> >>>>> DATA_SET(test, test2); >>>>> DATA_SET(test, test3); >>>>> >>>>> It breaks on powerpc64. Should be very easy to reproduce. >>>>> >>>>> The problem with SYSCTL's is that some are global and some are not. >>>>> Before an indirect pointer was hiding this problem from appearing. >>>>> >>>>> Do you see? Or do you want me to explain more. >>>> >>>> Ahh, ok. Seems odd that this sort of thing would be ppc64-specific however. >>>> >>> >>> Apparently it isn't and has also has shown up on at least ia64: >>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=31490 >> >> Ugh. Maybe this should be conditional on the GCC version rather than ppc64? > > There should also be a GCC bug id in a comment. > Hi, Feel free to update my patch for linker_set.h. This is beyond what I feel comfortable at :-) BTW: Is it possible to import those GCC patches into base? Thank you! --HPS