From owner-freebsd-current@FreeBSD.ORG Wed Mar 17 20:53:18 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1D5631065676; Wed, 17 Mar 2010 20:53:18 +0000 (UTC) (envelope-from marius@nuenneri.ch) Received: from mail-wy0-f182.google.com (mail-wy0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id 8F7028FC12; Wed, 17 Mar 2010 20:53:17 +0000 (UTC) Received: by wyb33 with SMTP id 33so759741wyb.13 for ; Wed, 17 Mar 2010 13:53:16 -0700 (PDT) MIME-Version: 1.0 Received: by 10.216.86.3 with SMTP id v3mr781462wee.190.1268859196230; Wed, 17 Mar 2010 13:53:16 -0700 (PDT) In-Reply-To: References: From: =?UTF-8?Q?Marius_N=C3=BCnnerich?= Date: Wed, 17 Mar 2010 21:52:56 +0100 Message-ID: To: kmacy@freebsd.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: freebsd-current@freebsd.org Subject: Re: ARCS_LOCK_PAD or padding and aligning of mutex structures X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Mar 2010 20:53:18 -0000 On Wed, Mar 17, 2010 at 12:02, Marius N=C3=BCnnerich w= rote: > Hi Kip, > > I wondered if one shouldn't use CACHE_LINE_SIZE for ARCS_LOCK_PAD > instead of hardcoding 128? And maybe even use it for aligning the > struct, see http://fxr.watson.org/fxr/source/vm/vm_page.h#L176 . I actually meant arc.c line 227. The __aligned like in vm_page.h is not nee= ded?