From owner-freebsd-current Fri Jun 4 12:55:46 1999 Delivered-To: freebsd-current@freebsd.org Received: from herring.nlsystems.com (nlsys.demon.co.uk [158.152.125.33]) by hub.freebsd.org (Postfix) with ESMTP id 67C51155AA for ; Fri, 4 Jun 1999 12:54:42 -0700 (PDT) (envelope-from dfr@nlsystems.com) Received: from localhost (dfr@localhost) by herring.nlsystems.com (8.9.3/8.8.8) with ESMTP id UAA27132; Fri, 4 Jun 1999 20:54:53 +0100 (BST) (envelope-from dfr@nlsystems.com) Date: Fri, 4 Jun 1999 20:54:48 +0100 (BST) From: Doug Rabson To: Bruce Evans Cc: nick.hibma@jrc.it, roger@cs.strath.ac.uk, current@freebsd.org, phk@critter.freebsd.dk Subject: Re: cdevsw_add In-Reply-To: <199906041425.AAA00619@godzilla.zeta.org.au> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sat, 5 Jun 1999, Bruce Evans wrote: > >> Hm, I think this a bad choice. Which are 'all the other drivers'? The > >> probe should really be as thin as possible to avoid unnecessary delays > >> when probing in a kernel, like GENERIC, with a lot of device drivers > >> compiled in. > > > >Well, in the PCI drivers, it is just the meteor, the brooktree848 > >and the Xilinx PGA driver (xrpu) > > > >In the /sys/i386/isa drivers, there were quite a few. > > The isa drivers provide many bad examples. Most of them attached the > devsw in a disgusting SYSINIT even if the device is disabled. I moved > the devsw attach to the device attach function in some drivers that > I worked on. This was necessary to support pcvt and syscons sharing a > devsw entry. If people feel that its wrong to put the cdev registration in a sysinit, please feel free to rip out the DEV_DRIVER_MODULE stuff and replace it with whatever the 'right thing' is. -- Doug Rabson Mail: dfr@nlsystems.com Nonlinear Systems Ltd. Phone: +44 181 442 9037 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message