Date: Thu, 28 Mar 2013 10:11:49 +0400 From: Eygene Ryabinkin <rea@freebsd.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Xin LI <delphij@FreeBSD.org>, ports-committers@freebsd.org Subject: Re: svn commit: r315412 - head/security/vuxml Message-ID: <y6wrz9PFYnyLw6do0J4WTT7Agfw@7Kz%2BGRmbm4U3A9gdU2CEwxjTOhk> In-Reply-To: <20130328024114.GA72629@FreeBSD.org> References: <201303272044.r2RKipXq050003@svn.freebsd.org> <20130328024114.GA72629@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--nO3oAMapP4dBpMZi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Thu, Mar 28, 2013 at 02:41:14AM +0000, Alexey Dokuchaev wrote: > On Wed, Mar 27, 2013 at 08:44:51PM +0000, Xin LI wrote: > > New Revision: 315412 > > URL: http://svnweb.freebsd.org/changeset/ports/315412 > >=20 > > Log: > > Explicitly use -E for sed(1). > > =20 > > Submitted by: des > > Reviewed by: eadler > >=20 > > - @unexpand "${VUXML_FILE}" | ${SED} 's,[[:space:]]*$$,,g' > "${VUXML_F= ILE}.unexpanded" > > + @unexpand "${VUXML_FILE}" | ${SED} -E 's,[[:space:]]*$$,,g' > "${VUXM= L_FILE}.unexpanded" >=20 > Why -e is insufficient here? Well, slightly better question is 'why had you added -E that enabled modern re processing', because the change from '${SED} <pattern>' to '${SED} -e <pattern>' is a no-op. And the right answer is "That was a redundant change": {{{ $ echo SSBoYXZlIHRyYWlsaW5nIHNwYWNlLCBjbGVhbiBtZSEJCSAK | openssl base64 -d= | sed 's/[[:space:]]*$/<fixed>/g' I have trailing space, clean me!<fixed> $ echo SSBoYXZlIHRyYWlsaW5nIHNwYWNlLCBjbGVhbiBtZSEJCSAK | openssl base64 -d= | sed -E 's/[[:space:]]*$/<fixed>/g' I have trailing space, clean me!<fixed> }}} We will try to fix that or to understand why des@ suggested it, thanks for spotting! --=20 Eygene Ryabinkin ,,,^..^,,, [ Life's unfair - but root password helps! | codelabs.ru ] [ 82FE 06BC D497 C0DE 49EC 4FF0 16AF 9EAE 8152 ECFB | freebsd.org ] --nO3oAMapP4dBpMZi Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iF4EABEIAAYFAlFT3yUACgkQFq+eroFS7PtRaAEAhrRZIjucgRPVn7H+gWbqsaW1 QeNgWev7hPfw2C2KhWUA/2Ict4DVfO06xeQ8XLNO151DI/WcIdmlL24bganSpBYt =zytk -----END PGP SIGNATURE----- --nO3oAMapP4dBpMZi--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?y6wrz9PFYnyLw6do0J4WTT7Agfw>