From owner-svn-src-all@FreeBSD.ORG Sat Dec 21 16:08:28 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 56C3437E; Sat, 21 Dec 2013 16:08:28 +0000 (UTC) Received: from mx1.fisglobal.com (mx1.fisglobal.com [199.200.24.190]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 121781F5B; Sat, 21 Dec 2013 16:08:27 +0000 (UTC) Received: from smtp.fisglobal.com ([10.132.206.15]) by ltcfislmsgpa06.fnfis.com (8.14.5/8.14.5) with ESMTP id rBLG8Lel023986 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Sat, 21 Dec 2013 10:08:21 -0600 Received: from LTCFISWMSGMB21.FNFIS.com ([169.254.1.7]) by LTCFISWMSGHT04.FNFIS.com ([10.132.206.15]) with mapi id 14.03.0158.001; Sat, 21 Dec 2013 10:08:19 -0600 From: "Teske, Devin" To: Nathan Whitehorn Subject: Re: svn commit: r259468 - head/usr.sbin/bsdinstall/scripts Thread-Topic: svn commit: r259468 - head/usr.sbin/bsdinstall/scripts Thread-Index: AQHO/mbdkcgFyHyrTEqBVO9KeR/sVQ== Date: Sat, 21 Dec 2013 16:08:18 +0000 Message-ID: References: <201312161550.rBGFox0N001344@svn.freebsd.org> <52AF2502.1060503@freebsd.org> <52B5AA94.3060009@freebsd.org> In-Reply-To: <52B5AA94.3060009@freebsd.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-originating-ip: [10.132.253.120] Content-Type: multipart/mixed; boundary="_004_DE2B2BE16A884A1CAADAB6308630634Efisglobalcom_" MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.11.87, 1.0.14, 0.0.0000 definitions=2013-12-21_01:2013-12-20,2013-12-21,1970-01-01 signatures=0 X-Content-Filtered-By: Mailman/MimeDel 2.1.17 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , Devin Teske , "src-committers@freebsd.org" , "Teske, Devin" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list Reply-To: Devin Teske List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Dec 2013 16:08:28 -0000 --_004_DE2B2BE16A884A1CAADAB6308630634Efisglobalcom_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I tried to rationalize... "in what case is it actually _desirably_ that the left or right command key _should_ generate an escape sequence and thus cancel the existing dialog" and I couldn't think of any. That being said... I'm still happy to move it. Can you have a look at the attached patch to see if matches what you envision? -- Devin On Dec 21, 2013, at 6:49 AM, Nathan Whitehorn wrote: > Could you please revert this and move the fix to the correct place? > -Nathan > > On 12/16/13 10:06, Nathan Whitehorn wrote: >> Please add this to release/rc.local instead under the console setup. >> There is no guarantee that "auto" is running from an environment where >> this is defined -- for example, it may be running from a serial >> console or an xterm -- and the actual installer should not be polluted >> with assumptions about the media from which it runs. >> -Nathan >> >> On 12/16/13 09:50, Devin Teske wrote: >>> Author: dteske >>> Date: Mon Dec 16 15:50:59 2013 >>> New Revision: 259468 >>> URL: https://urldefense.proofpoint.com/v1/url?u=3Dhttp://svnweb.freebsd= .org/changeset/base/259468&k=3D%2FbkpAUdJWZuiTILCq%2FFnQg%3D%3D%0A&r=3DMrjs= 6vR4%2Faj2Ns9%2FssHJjg%3D%3D%0A&m=3DVPzUmM2go2WySxuU4i4nAG5Ox61QodkXwD4Z7Ca= Xvls%3D%0A&s=3Daed75882069cc72d4a372f6471f113be19fcb6eeeca132b424719ac3b459= e2a3 >>> >>> Log: >>> Add a fix for Long-standing problem with VMware. Described in >>> below links: >>> https://urldefense.proofpoint.com/v1/url?u=3Dhttps://communities.vmwa= re.com/thread/107230&k=3D%2FbkpAUdJWZuiTILCq%2FFnQg%3D%3D%0A&r=3DMrjs6vR4%2= Faj2Ns9%2FssHJjg%3D%3D%0A&m=3DVPzUmM2go2WySxuU4i4nAG5Ox61QodkXwD4Z7CaXvls%3= D%0A&s=3Deb4a25314cb93209718bd46c3a142e1a92fac348d3cdf720b26f416b6061cd17 >>> https://urldefense.proofpoint.com/v1/url?u=3Dhttps://communities.vmwa= re.com/docs/DOC-11677&k=3D%2FbkpAUdJWZuiTILCq%2FFnQg%3D%3D%0A&r=3DMrjs6vR4%= 2Faj2Ns9%2FssHJjg%3D%3D%0A&m=3DVPzUmM2go2WySxuU4i4nAG5Ox61QodkXwD4Z7CaXvls%= 3D%0A&s=3D2837df54aadfa9de8e081ac53a233ed2dc52f2f4a2be08ae75fefcdd4ee1ddbd >>> Basically, ignore the ``function 62'' and ``function 63'' >>> interpretations >>> of the left/right command key when we're in the lengthiest portion >>> of the >>> installation (initiated by the `auto' module). >>> The net effect is that you can now (once you've started the >>> installer from >>> the media) escape the VM without prematurely terminating the >>> current action >>> due to spurious escape sequence. >>> MFC after: 3 days >>> >>> Modified: >>> head/usr.sbin/bsdinstall/scripts/auto >>> >>> Modified: head/usr.sbin/bsdinstall/scripts/auto >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D >>> >>> --- head/usr.sbin/bsdinstall/scripts/auto Mon Dec 16 15:08:30 >>> 2013 (r259467) >>> +++ head/usr.sbin/bsdinstall/scripts/auto Mon Dec 16 15:50:59 >>> 2013 (r259468) >>> @@ -49,6 +49,10 @@ error() { >>> ############################################################ MAIN >>> +# Don't send ESC on function-key 62/63 (left/right command key) >>> +f_quietly kbdcontrol -f 62 '' >>> +f_quietly kbdcontrol -f 63 '' >>> + >>> f_dprintf "Began Installation at %s" "$( date )" >>> rm -rf $BSDINSTALL_TMPETC >> > _____________ The information contained in this message is proprietary and/or confidentia= l. If you are not the intended recipient, please: (i) delete the message an= d all copies; (ii) do not disclose, distribute or use the message in any ma= nner; and (iii) notify the sender immediately. In addition, please be aware= that any message addressed to our domain is subject to archiving and revie= w by persons other than the intended recipient. Thank you. --_004_DE2B2BE16A884A1CAADAB6308630634Efisglobalcom_ Content-Type: text/plain; name="patch.txt" Content-Description: patch.txt Content-Disposition: attachment; filename="patch.txt"; size=1035; creation-date="Sat, 21 Dec 2013 16:08:18 GMT"; modification-date="Sat, 21 Dec 2013 16:08:18 GMT" Content-ID: <668BD9BA105D2E4C93304124F1A724C4@fisglobal.com> Content-Transfer-Encoding: base64 SW5kZXg6IHJlbGVhc2UvcmMubG9jYWwNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSByZWxlYXNlL3JjLmxvY2Fs CShyZXZpc2lvbiAyNTk2ODQpDQorKysgcmVsZWFzZS9yYy5sb2NhbAkod29ya2luZyBjb3B5KQ0K QEAgLTE5LDYgKzE5LDEwIEBAIGlmIFsgJD8gLWVxIDAgXTsgdGhlbg0KIAkJVEVSTT14dGVybQ0K IAlmaQ0KIA0KKwkjIERvbid0IHNlbmQgRVNDIG9uIGZ1bmN0aW9uLWtleSA2Mi82MyAobGVmdC9y aWdodCBjb21tYW5kIGtleSkNCisJZl9xdWlldGx5IGtiZGNvbnRyb2wgLWYgNjIgJycNCisJZl9x dWlldGx5IGtiZGNvbnRyb2wgLWYgNjMgJycNCisNCiAJaWYgWyAteiAiJEVYVEVSTkFMX1ZUWV9T VEFSVEVEIiBdOyB0aGVuDQogCQkjIEluaXQgd2lsbCBjbGVhbiB0aGVzZSBwcm9jZXNzZXMgdXAg aWYvd2hlbiB0aGUgc3lzdGVtDQogCQkjIGdvZXMgbXVsdGl1c2VyDQpJbmRleDogdXNyLnNiaW4v YnNkaW5zdGFsbC9zY3JpcHRzL2F1dG8NCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSB1c3Iuc2Jpbi9ic2RpbnN0 YWxsL3NjcmlwdHMvYXV0bwkocmV2aXNpb24gMjU5NjE4KQ0KKysrIHVzci5zYmluL2JzZGluc3Rh bGwvc2NyaXB0cy9hdXRvCSh3b3JraW5nIGNvcHkpDQpAQCAtNDksMTAgKzQ5LDYgQEAgZXJyb3Io KSB7DQogDQogIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMj IyMjIyMjIyMjIyMjIE1BSU4NCiANCi0jIERvbid0IHNlbmQgRVNDIG9uIGZ1bmN0aW9uLWtleSA2 Mi82MyAobGVmdC9yaWdodCBjb21tYW5kIGtleSkNCi1mX3F1aWV0bHkga2JkY29udHJvbCAtZiA2 MiAnJw0KLWZfcXVpZXRseSBrYmRjb250cm9sIC1mIDYzICcnDQotDQogZl9kcHJpbnRmICJCZWdh biBJbnN0YWxsYXRpb24gYXQgJXMiICIkKCBkYXRlICkiDQogDQogcm0gLXJmICRCU0RJTlNUQUxM X1RNUEVUQw0K --_004_DE2B2BE16A884A1CAADAB6308630634Efisglobalcom_--