From owner-freebsd-current@freebsd.org Sun Jul 31 01:40:00 2016 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 730C2BA217E for ; Sun, 31 Jul 2016 01:40:00 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm50-vm2.bullet.mail.bf1.yahoo.com (nm50-vm2.bullet.mail.bf1.yahoo.com [216.109.115.221]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 29D661ED4 for ; Sun, 31 Jul 2016 01:40:00 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1469929193; bh=JyEzUCBRlIUZtOdeznKYDPKdpE3vpDV+aRVy1Io7+WQ=; h=Subject:To:References:Cc:From:Date:In-Reply-To:From:Subject; b=C6aJFrVaKjOiC2V5O10FC0ZzZ8herkvnN9UAq7/tc2+ji+ImA9Hogv41SbuZG0DOJrhwzsTk5IlzvctQb2oLe4+zRSO8ZiHGyAlB/PnUryn+5WphQHXt30Gb+vvbnm12hfS70OOZPTD3rS/s1tz7LHxUGP54IpgXT0rtJ0hPvX9c8mlwp422FuShpdI/D9d+1e48m6FbPhOZ1srsA7bUixUUFcgxE0exblcE/S7mU8RzsMANs0SoIVPdawbMdPY4DH/B/bmqSUmE1+xdQQQAIGpSq2PwQKD554Ifx6v5rV+nnySoaJPebAy4McK0yxVaiZKECndpYspY3aeOwZ5QIg== Received: from [66.196.81.174] by nm50.bullet.mail.bf1.yahoo.com with NNFMP; 31 Jul 2016 01:39:53 -0000 Received: from [68.142.230.77] by tm20.bullet.mail.bf1.yahoo.com with NNFMP; 31 Jul 2016 01:39:53 -0000 Received: from [127.0.0.1] by smtp234.mail.bf1.yahoo.com with NNFMP; 31 Jul 2016 01:39:53 -0000 X-Yahoo-Newman-Id: 741414.72150.bm@smtp234.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: EwPrS3QVM1k2Y6hrnkPuZSI1JqGzPi3Sz0BJY2TzPRabPhf pUPWBOSLtjrqSCMDNQ4LYVjm3dLURhFbpWrJG8IQ_PUp9Jr1igxt42p4IQio bj1TOiY.X7ZmZo4lLtRhf_ex1Zv0jj54RQZI7PWF_21WafsCq_._jfYBYg9T EPQKtselc1v8nPAZHNNefnD2p2nAkg4VELR0PWXnoJrLQm3HhRJBEXztHwic VO3UHL5tru9SVgsme5_nnBtu95N5I4I3GYVHwJN6sLQTMjlmaEFW2R7Sbee6 xERRvaKLrcJm5yzNfGp5h0Y6qqDfODI5dx80mxKv_V5nPxI7zNKNAm8qekR2 XTi9wTjeb69VY1t3yKnJF_A8M4cqyaaCYf9YyshniNlylOnBkAXhzBEw.YjJ LRKvK7wEOtoJuSmejS2Qg8D7AHcgS8YwFDAhY8vbBx.7c2eVVPK4c14XfPIC LxscbUaOF9Hfh5k7cYM3AaqqNgGQyT2T9fV6bmxnsSoOIeXLD6euEUJaBQy4 Qzixl6p2wlu4MLW.yvDNFoBG1LQYwDKMzntkrqtixGMNnRA-- X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Subject: Re: resolvconf needs @RESTARTCMD@ to be replaced after r303062 To: Guy Yur , freebsd-current References: Cc: Glen Barber From: Pedro Giffuni Message-ID: Date: Sat, 30 Jul 2016 20:40:02 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------7C20F263BA11AFA65996691B" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Jul 2016 01:40:00 -0000 This is a multi-part message in MIME format. --------------7C20F263BA11AFA65996691B Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit (CC'ing Glen for review, since he was the last to touch that file and may know better). Hi Guy; On 07/30/16 17:37, Guy Yur wrote: > Hi, > > openresolv 3.8.1 added RESTARTCMD=@RESTARTCMD@ in > contrib/openresolv/resolvconf.in. > It is not replaced by the sed expressions in sbin/resolvconf/Makefile. > > Error seen is "eval: @RESTARTCMD@: not found". > > Current @RESTARTCMD \(.*\)@ sed expression needs to be kept for > pdns_recursor.in and a new expression added to replace @RESTARTCMD@. > I see, you mean here: https://svnweb.freebsd.org/base/head/sbin/resolvconf/Makefile?revision=298107&view=markup#l32 > The following worked for me: > RESTARTCMD_= "/usr/sbin/service \\$$1 onestatus >/dev/null 2>\&1 > \&\& /usr/sbin/service \\$$1 restart" > > sed ... \ > ... \ > -e 's:@RESTARTCMD@:${RESTARTCMD_}:g' \ > ... And perhaps something like the attached patch (is the underscore a typo?). I don't see the error message though. so I need some confirmation that this fixes the issue. Pedro. --------------7C20F263BA11AFA65996691B Content-Type: text/x-patch; name="resolvconf-restartcmd.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="resolvconf-restartcmd.diff" Index: sbin/resolvconf/Makefile =================================================================== --- sbin/resolvconf/Makefile (revision 303557) +++ sbin/resolvconf/Makefile (working copy) @@ -30,6 +30,7 @@ -e 's:@LIBEXECDIR@:${FILESDIR}:g' \ -e 's:@VARDIR@:${VARDIR}:g' \ -e 's:@RESTARTCMD \(.*\)@:${RESTARTCMD}:g' \ + -e 's:@RESTARTCMD@:${RESTARTCMD}:g' \ -e 's:@RCDIR@:${RCDIR}:g' \ -e 's: vpn : ng[0-9]*&:g' \ ${DIST}/$@.in > $@ --------------7C20F263BA11AFA65996691B--