From owner-freebsd-net@FreeBSD.ORG  Wed Oct 31 01:10:41 2007
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9A25716A46B;
	Wed, 31 Oct 2007 01:10:41 +0000 (UTC)
	(envelope-from matus.harvan@inf.ethz.ch)
Received: from XSMTP0.ethz.ch (xsmtp0.ethz.ch [82.130.70.14])
	by mx1.freebsd.org (Postfix) with ESMTP id E01BE13C48D;
	Wed, 31 Oct 2007 01:10:40 +0000 (UTC)
	(envelope-from matus.harvan@inf.ethz.ch)
Received: from xfe0.d.ethz.ch ([82.130.124.40]) by XSMTP0.ethz.ch with
	Microsoft SMTPSVC(6.0.3790.3959); Wed, 31 Oct 2007 01:53:06 +0100
Received: from styx.inf.ethz.ch ([77.56.100.193]) by xfe0.d.ethz.ch over TLS
	secured channel with Microsoft SMTPSVC(6.0.3790.3959); 
	Wed, 31 Oct 2007 01:53:06 +0100
Received: by styx.inf.ethz.ch (Postfix, from userid 1001)
	id 934E049AC8F; Wed, 31 Oct 2007 01:53:06 +0100 (CET)
Date: Wed, 31 Oct 2007 01:53:06 +0100
From: Matus Harvan <mharvan@inf.ethz.ch>
To: "Bruce M. Simpson" <bms@FreeBSD.org>
Message-ID: <20071031005306.GC2564@styx.ethz.ch>
References: <20070909204148.GB18107@inf.ethz.ch>
	<20071026155206.GH1049@styx.ethz.ch> <4722B6A3.6030606@FreeBSD.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="lCAWRPmW1mITcIfM"
Content-Disposition: inline
In-Reply-To: <4722B6A3.6030606@FreeBSD.org>
User-Agent: Mutt/1.5.16 (2007-06-09)
X-OriginalArrivalTime: 31 Oct 2007 00:53:06.0979 (UTC)
	FILETIME=[6670A730:01C81B58]
Cc: freebsd-net@freebsd.org, Brooks Davis <brooks@freebsd.org>,
	Max Laier <max@love2party.net>
Subject: Re: TCP listenall
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 31 Oct 2007 01:10:41 -0000


--lCAWRPmW1mITcIfM
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Oct 27, 2007 at 04:55:15AM +0100, Bruce M. Simpson wrote:
> listenallr is static and is going to get trashed by concurrent threads,=
=20
> unless there is a serialization with a lock, which I don't see.

I have used sys/netinet/ip_icmp.c:badport_bandlim() for
inspiration. There it did not seem to be protected by any locks
either. Would this be a bug in the ICMP code as well?

Matus

--lCAWRPmW1mITcIfM
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.4 (FreeBSD)

iD8DBQFHJ9Hy43LQWDWf0QIRAt5XAJ49l0PEBVBEEFjjuHKHxfv1PlFM9QCcDSvi
WGP36DZeEVTunRoXzf9nG/I=
=rl3D
-----END PGP SIGNATURE-----

--lCAWRPmW1mITcIfM--