Date: Fri, 19 Jun 2015 22:42:27 +0000 (UTC) From: John-Mark Gurney <jmg@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r284616 - head/sys/opencrypto Message-ID: <201506192242.t5JMgR8m006906@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: jmg Date: Fri Jun 19 22:42:26 2015 New Revision: 284616 URL: https://svnweb.freebsd.org/changeset/base/284616 Log: change the KASSERT so it is meaningful, var is unsigned, so even when it wraps, it's still >= 0... Reported by: Coverity CID: 1017564 Modified: head/sys/opencrypto/crypto.c Modified: head/sys/opencrypto/crypto.c ============================================================================== --- head/sys/opencrypto/crypto.c Fri Jun 19 22:40:58 2015 (r284615) +++ head/sys/opencrypto/crypto.c Fri Jun 19 22:42:26 2015 (r284616) @@ -1181,8 +1181,8 @@ crypto_kdone(struct cryptkop *krp) /* XXX: What if driver is loaded in the meantime? */ if (krp->krp_hid < crypto_drivers_num) { cap = &crypto_drivers[krp->krp_hid]; + KASSERT(cap->cc_koperations > 0, ("cc_koperations == 0")); cap->cc_koperations--; - KASSERT(cap->cc_koperations >= 0, ("cc_koperations < 0")); if (cap->cc_flags & CRYPTOCAP_F_CLEANUP) crypto_remove(cap); }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201506192242.t5JMgR8m006906>