From owner-svn-ports-head@freebsd.org  Wed Jul 15 23:43:01 2015
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3A1AB9A263C;
 Wed, 15 Jul 2015 23:43:01 +0000 (UTC)
 (envelope-from amdmi3@amdmi3.ru)
Received: from vps.amdmi3.ru (vps.amdmi3.ru [109.234.38.216])
 by mx1.freebsd.org (Postfix) with ESMTP id E976C18EF;
 Wed, 15 Jul 2015 23:43:00 +0000 (UTC)
 (envelope-from amdmi3@amdmi3.ru)
Received: from hive.panopticon (unknown [78.153.152.119])
 by vps.amdmi3.ru (Postfix) with ESMTPS id 8C28AB0614;
 Thu, 16 Jul 2015 02:42:52 +0300 (MSK)
Received: from hades.panopticon (hades.panopticon [192.168.0.32])
 by hive.panopticon (Postfix) with ESMTP id 4A248583;
 Thu, 16 Jul 2015 02:40:54 +0300 (MSK)
Received: by hades.panopticon (Postfix, from userid 1000)
 id 90B8180B77; Thu, 16 Jul 2015 02:39:32 +0300 (MSK)
Date: Thu, 16 Jul 2015 02:39:32 +0300
From: Dmitry Marakasov <amdmi3@amdmi3.ru>
To: Mathieu Arnold <mat@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r392209 - in head/devel: . p5-Minilla
Message-ID: <20150715233932.GF6337@hades.panopticon>
References: <201507152017.t6FKHElA056017@svnmir.geo.freebsd.org>
 <F55E1B42FC419AF2D5795884@atuin.in.mat.cc>
 <20150715204943.GK97479@hades.panopticon>
 <1F084648031C9C61AABC041D@atuin.in.mat.cc>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1F084648031C9C61AABC041D@atuin.in.mat.cc>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Jul 2015 23:43:01 -0000

* Mathieu Arnold (mat@FreeBSD.org) wrote:

> |> | +RUN_DEPENDS:=	${BUILD_DEPENDS}
> |> 
> |> Please, do *not* use := for depends, it is wrong.
> |> <https://www.freebsd.org/doc/en/books/porters-handbook/makefile-depend.h
> |> tml>
> | 
> | First, mail submitter, not me.
> 
> I'm sorry, but no, you are the one committing it, thus, you are responsible
> for it to be up to our standards.

Yes, and I see nothing wrong with it.

> | Next, handbook doesn't say anything against :=.
> 
> That is right, but the handbook tells you to do something else, that is,
> use a third variable, I'll add a bit about never using := tomorrow.

The way it is now it's nothing more than a mere suggestion.

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3@amdmi3.ru  ..:  jabber: amdmi3@jabber.ru      http://amdmi3.ru