From nobody Fri Jun 26 23:36:13 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gnBrY6LQxz6j8J0 for ; Fri, 26 Jun 2026 23:36:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gnBrY58bzz42JZ for ; Fri, 26 Jun 2026 23:36:13 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782516973; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yuyuL7UxYI/YciZA+47/q2hTU+4d/pF2UKw5cq2AUMQ=; b=aifqDKejXtaKdKbPO6uEMJv7cEC86OERG+Xhyf6wZZJoluA6fW5dFXv6s/HCcJUcKQUBTP JkLSUWN7hP8VvqJyD6LDNXrj8C0FiQ/wBQ1WlUQSzPykYLOAMC7DwR3W6y+JRPsjRwWXxx HSGYu88Lipnf7KKOIhtK2OYgMZJmrHwB9KOejxyeO6B8q6WPWaC34LxUBDGEHGwBmSBMEs +azVB7vjq2N8rBMyqSuCb2rA/53+Gaf5ZZt6xeP0pVxjM1DwwVTABKAEFM2W5cwQLsi9V8 jPIfurNYJxsGBaDGvtZ5XxO3aCNeMKXOcakTpNF4VvNIz0OUvs6Sx0WSvlx6wA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1782516973; a=rsa-sha256; cv=none; b=wI3Wr4qswzJCbDLVFoV5Il6hFQlcucfbgPmIP8tVe+j7KfTigxkeaKl/YL2K542TBzY9Hj AKmfJx8Dk5fWv7aGTDQT2jMWYt4mX2kzq4Pn0NVVwLzeDIvXe1lnjiZLR1r2LEnDy7LjS/ y1h+K3o9XN07LhM02/+eaxoo4snMDGK/DtUh+WckIWjcxaRjE7YCIo4SrWpDlPleBePl7W p6gD+slAKqYM8m0w0B69DGDozZFONTskhigh7Mede4VQp8uG4oTPWNSWOA0vEXiFvWK3RJ gZHaFzWWAMMXcBtkcj2vECAFa10Ehjp61QUu/orw/xBXRvQorBG7A2i1zK7nqQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782516973; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yuyuL7UxYI/YciZA+47/q2hTU+4d/pF2UKw5cq2AUMQ=; b=txHdWCmBvNx2n3TN1/Uk/onby8iE1j+bPfdUlBhqANNRhIL4ACy2u1n4z+gif2N73ccAyC GYKHtbxMPlB+76M2dk3srlgQSua9in03S8LiQyT5foR5jA4fsGohJW5baG7BEmt8EFzYGJ 4VVhv/BxIDyWyL8Esfst1UEHdw0M8HJSX0v8Eb1z1Q6Ybm8EwnFDeRw2MvPzGK06sG/PWk HnbwsSngkodrpJhih8aym++94CzZ8VxK/U91ayeENSNYVVW4AWGn5A9wESBVDDLV9Q/e03 mYQ63IiAc4/202sN+Se0/UWAxPevsYLMRU6vc3i2wuuxaRsKNRv44z8FCSDUlw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gnBrY3x0bz10TH for ; Fri, 26 Jun 2026 23:36:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 38f81 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 26 Jun 2026 23:36:13 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Gleb Smirnoff Subject: git: 4d3cbeb7b407 - main - ng_socket: plug node reference leak List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: glebius X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 4d3cbeb7b407e127a5364f86039745068fbfc61f Auto-Submitted: auto-generated Date: Fri, 26 Jun 2026 23:36:13 +0000 Message-Id: <6a3f0ced.38f81.7590f40e@gitrepo.freebsd.org> The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=4d3cbeb7b407e127a5364f86039745068fbfc61f commit 4d3cbeb7b407e127a5364f86039745068fbfc61f Author: Gleb Smirnoff AuthorDate: 2026-06-26 23:03:14 +0000 Commit: Gleb Smirnoff CommitDate: 2026-06-26 23:35:36 +0000 ng_socket: plug node reference leak There is no need to reference node in its constructor, the framework already granted us a reference. This extraneous reference was later given back on socket detach. However, if node is destroyed before the socket, the node was leaked. This leak was harmless until VIMAGE, where vnet_netgraph_uninit() would cycle through all nodes and shut them down expecting them to not exist after the shutdown. Fixes: 19284374970533e1aa04020d4f840e8877ed6266 --- sys/netgraph/ng_socket.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sys/netgraph/ng_socket.c b/sys/netgraph/ng_socket.c index e08027693f32..9dbdc499bb0e 100644 --- a/sys/netgraph/ng_socket.c +++ b/sys/netgraph/ng_socket.c @@ -506,7 +506,6 @@ ngc_attach(struct socket *so, int type, struct thread *td) /* Link the node and the private data. */ NG_NODE_SET_PRIVATE(priv->node, priv); - NG_NODE_REF(priv->node); priv->refs++; return (0); @@ -602,7 +601,6 @@ ng_socket_free_priv(struct ngsock *priv) priv->node = NULL; mtx_unlock(&priv->mtx); - NG_NODE_UNREF(node); ng_rmnode_self(node); } else mtx_unlock(&priv->mtx);