From owner-freebsd-hackers Tue Sep 19 12:03:54 1995 Return-Path: owner-hackers Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id MAA24410 for hackers-outgoing; Tue, 19 Sep 1995 12:03:54 -0700 Received: from phaeton.artisoft.com (phaeton.Artisoft.COM [198.17.250.211]) by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id MAA24400 for ; Tue, 19 Sep 1995 12:03:49 -0700 Received: (from terry@localhost) by phaeton.artisoft.com (8.6.11/8.6.9) id LAA10358; Tue, 19 Sep 1995 11:58:37 -0700 From: Terry Lambert Message-Id: <199509191858.LAA10358@phaeton.artisoft.com> Subject: Re: why is this not a bug in namei? To: davidg@root.com Date: Tue, 19 Sep 1995 11:58:37 -0700 (MST) Cc: julian@ref.tfs.com, terry@lambert.org, hackers@freefall.freebsd.org In-Reply-To: <199509190636.XAA03898@corbin.Root.COM> from "David Greenman" at Sep 18, 95 11:36:03 pm X-Mailer: ELM [version 2.4 PL24] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Length: 1057 Sender: owner-hackers@FreeBSD.org Precedence: bulk > There are a few formatting issues which I probably will fix. The problem > I'm having is basically that we have a specific style that we are trying to > adhere to (surely everone can understand the readability advantages of a > single coding style - KNF), and Terry wants to add a few hundred gotos while > he rewrites everything. Yuck. > I really wish that people would spend more time on fixing real problems > with the source code and not just changing it to fit their own non-KNF style. > It's only going to result in a lot more work later when someone has to go > back and "fix" all of it. KNF is why we have GNU Indent. If you don't like goto's, fine, you keep the multiple deallocations and lock/unlock's code synchronized after removing them. The goto's aren't an issue of KNF or not KNF. That's more where I put my parenthesis. GNU Indent should be part of CVS checking if you're that religious. Terry Lambert terry@lambert.org --- Any opinions in this posting are my own and not those of my present or previous employers.